Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-22 Thread Justin Lu
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-20 Thread Iris Clark
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-20 Thread Justin Lu
On Wed, 20 Nov 2024 07:20:32 GMT, Laurent Bourgès wrote: > I will check today if any 'bad' pattern is remaining in the openjdk master > source folder... to be sure. > > Maybe improving jni documentation would be great in another issue... Thanks for checking @bourgesl. The JNI docs did in fact

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-19 Thread Laurent Bourgès
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-19 Thread Alan Bateman
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-19 Thread Laurent Bourgès
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-19 Thread Justin Lu
Please review this PR which removes the leftover ocurrences of incorrect JNI `ExceptionOccurred(env)` usage within _java.base_. This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While these occurrences are fine and were intentionally not removed during the first pass, it