Re: RFR: 8344461: Additional cleanup in NewThreadAction [v2]

2024-12-04 Thread Stuart Marks
On Wed, 4 Dec 2024 19:48:03 GMT, Roger Riggs wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make thread group fields final. > > src/java.rmi/share/classes/sun/rmi/runtime/RuntimeUtil.java line 60: > >> 58: *

Re: RFR: 8344461: Additional cleanup in NewThreadAction [v2]

2024-12-04 Thread Roger Riggs
On Wed, 4 Dec 2024 22:35:08 GMT, Stuart Marks wrote: >> Convert the RMI NewThreadAction class into a couple static methods on >> RuntimeUtil. Also remove a couple unnecessary qualified exports from >> java.base to java.rmi. > > Stuart Marks has updated the pull request incrementally with one ad

Re: RFR: 8344461: Additional cleanup in NewThreadAction [v2]

2024-12-04 Thread Stuart Marks
> Convert the RMI NewThreadAction class into a couple static methods on > RuntimeUtil. Also remove a couple unnecessary qualified exports from > java.base to java.rmi. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Make thread grou

Re: RFR: 8344461: Additional cleanup in NewThreadAction

2024-12-04 Thread Roger Riggs
On Wed, 4 Dec 2024 19:06:20 GMT, Stuart Marks wrote: > Convert the RMI NewThreadAction class into a couple static methods on > RuntimeUtil. Also remove a couple unnecessary qualified exports from > java.base to java.rmi. src/java.rmi/share/classes/sun/rmi/runtime/RuntimeUtil.java line 60: > 5

Re: RFR: 8344461: Additional cleanup in NewThreadAction

2024-12-04 Thread Stuart Marks
On Wed, 4 Dec 2024 19:23:47 GMT, Roger Riggs wrote: >> Convert the RMI NewThreadAction class into a couple static methods on >> RuntimeUtil. Also remove a couple unnecessary qualified exports from >> java.base to java.rmi. > > Looks good, thanks for the cleanup @RogerRiggs Thanks, I'll integra

Re: RFR: 8344461: Additional cleanup in NewThreadAction

2024-12-04 Thread Roger Riggs
On Wed, 4 Dec 2024 19:06:20 GMT, Stuart Marks wrote: > Convert the RMI NewThreadAction class into a couple static methods on > RuntimeUtil. Also remove a couple unnecessary qualified exports from > java.base to java.rmi. Looks good, thanks for the cleanup - Marked as reviewed by

RFR: 8344461: Additional cleanup in NewThreadAction

2024-12-04 Thread Stuart Marks
Convert the RMI NewThreadAction class into a couple static methods on RuntimeUtil. Also remove a couple unnecessary qualified exports from java.base to java.rmi. - Commit messages: - 8344461: clean up NewThreadAction Changes: https://git.openjdk.org/jdk/pull/22557/files Webrev: