Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Brent Christian
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which cleans up SecurityManager-related code in >> `java.sql` and `java.sql.rowset` modules post JEP-486 >> >> There are quite a few changes to review, but all relatively straightforward: >> >> `DriverManager` >>

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Brent Christian
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which cleans up SecurityManager-related code in >> `java.sql` and `java.sql.rowset` modules post JEP-486 >> >> There are quite a few changes to review, but all relatively straightforward: >> >> `DriverManager` >>

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Eirik Bjørsnøs
On Mon, 18 Nov 2024 21:20:02 GMT, Chen Liang wrote: >> Eirik Bjørsnøs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove ObjectStreamField#getType from UNSUPPORTED_VIRTUAL_METHODS, a >> leftover from JDK-8344034 > > test/jdk/jdk/int

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Chen Liang
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which cleans up SecurityManager-related code in >> `java.sql` and `java.sql.rowset` modules post JEP-486 >> >> There are quite a few changes to review, but all relatively straightforward: >> >> `DriverManager` >>

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Roger Riggs
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which cleans up SecurityManager-related code in >> `java.sql` and `java.sql.rowset` modules post JEP-486 >> >> There are quite a few changes to review, but all relatively straightforward: >> >> `DriverManager` >>

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules [v4]

2024-11-18 Thread Eirik Bjørsnøs
> Please review this PR which cleans up SecurityManager-related code in > `java.sql` and `java.sql.rowset` modules post JEP-486 > > There are quite a few changes to review, but all relatively straightforward: > > `DriverManager` > * Remove `SecurityManager::checkPermission` calls in the `setLogW