Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Iris Clark
On Mon, 25 Nov 2024 21:02:35 GMT, Sean Mullan wrote: >> We want to `@SuppressWarnings("restricted")` the `loadLibrary()` call. IIUC, >> I can't `@SuppressWarnings` the static block, nor the call to >> `loadLibrary()`, so AFAICT that call needs to be in a separate, >> `@SuppressWarnings`-ed met

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Iris Clark
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Sean Mullan
On Mon, 25 Nov 2024 20:55:10 GMT, Brent Christian wrote: >> src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java >> line 87: >> >>> 85: @SuppressWarnings("restricted") >>> 86: private static void loadPrefsLib() { >>> 87: System.loadLibrary("prefs"); >> >> Wh

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Brent Christian
On Mon, 25 Nov 2024 19:11:02 GMT, Iris Clark wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spacing changes > > src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java line > 87: > >> 85:

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Iris Clark
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Brian Burkhalter
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Lance Andersen
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-25 Thread Roger Riggs
On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

2024-11-21 Thread Brent Christian
> Remove usages of SecurityManager, doPrivildged, and AccessController from the > java.prefs module. Brent Christian has updated the pull request incrementally with one additional commit since the last revision: spacing changes - Changes: - all: https://git.openjdk.org/jdk/pul