On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/2
On Mon, 18 Nov 2024 21:06:11 GMT, Sean Mullan wrote:
> Is this worthy of a release note?
There are hundreds of methods changed to no longer do permission checks,
remaining permission checks do nothing anyway. I would think the big release
note for JEP 486 will provide an overall summary of th
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Marked as reviewed by mullan (Reviewer).
Is this worthy of a release note?
-
PR Review
On Mon, 18 Nov 2024 20:35:49 GMT, Sean Mullan wrote:
> What about `sun.misc.Unsafe`? There are a couple of
> `AccessController.doPrivileged` calls.
I'll look at that in a separate PR.
-
PR Comment: https://git.openjdk.org/jdk/pull/22158#issuecomment-2484111717
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
What about `sun.misc.Unsafe`? There are a couple of
`AccessController.doPrivileged` calls.
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
CSR created, please review:
[JDK-8344423](https://bugs.openjdk.org/browse/JDK-8344423)
On Sat, 16 Nov 2024 07:59:15 GMT, Alan Bateman wrote:
> The CSR for JEP 486 included all the API changes for the supported APIs. With
> this PR we are in grey area of "critical internal APIs" that are
> undocumented. We have been doing CSRs whenever we remove these anything from
> jdk.unsuppor
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
The CSR for JEP 486 included all the API changes for the supported APIs. With
this PR we are in grey
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Thanks. I think these are all to clean up in ReflectionFactory.
-
Marked as reviewed b
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
The `jdk.unsupported` module is not part of the specification.
The JEP and CSR covered the removal of
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
Good. We might need a CSR as this changes API specification.
-
PR Review: https://git.
This cleanup of the use of SecurityManager is in the jdk.unsupported module.
Removed the permission check to call getReflectionFactory().
-
Commit messages:
- 8344327: SM cleanup in jdk.unsupported ReflectionFactory
Changes: https://git.openjdk.org/jdk/pull/22158/files
Webrev: htt
12 matches
Mail list logo
