On Fri, 15 Nov 2024 20:10:45 GMT, Doug Lea wrote:
> A side question: Are there now any situations in which Thread.interrupt can
> throw an exception? If not, a few more things in j.u.c and elsewhere could be
> simplified someday.
It's possible to extend Thread and override interrupt so in theo
On Fri, 15 Nov 2024 17:46:07 GMT, Roger Riggs wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> Roger Riggs has updated the
On Fri, 15 Nov 2024 15:46:53 GMT, Roger Riggs wrote:
>> Deleting it would also mean removing or modifying a bunch of j.u./tck tests.
>> Perhaps deprecation is enough.
>
> ok, for future cleanup
Although it is barely conceivable that someone is using it for the sake of
capturing the current cla
On Fri, 15 Nov 2024 17:46:07 GMT, Roger Riggs wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> Roger Riggs has updated the
On Fri, 15 Nov 2024 15:56:33 GMT, Roger Riggs wrote:
>> I agree on both counts with Alan: The FJP changes are not quite right, and
>> in any case should be postponed until after current FJP PR, and then further
>> simplified, which would be easiest if I did this.
>
> @DougLea If you prefer, I c
On Fri, 15 Nov 2024 17:32:38 GMT, Alan Bateman wrote:
>> ok, removing package access check
>
> I see you've removed it from AtomicIntegerFieldUpdater. There are also
> checkPackageAccess usages in AtomicLongFieldUpdater and
> AtomicReferenceFieldUpdater.
also removed
-
PR Review
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Fri, 15 Nov 2024 15:47:43 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java
>> line 399:
>>
>>> 397: if ((ccl != null) && (ccl != cl) &&
>>> 398: ((cl == null) || !isAncestor(cl, ccl))) {
>>>
On Fri, 15 Nov 2024 13:30:34 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
>>
>>> 1106: implements ForkJoinWorkerThreadFactory {
>>> 1107: public final ForkJoinWorkerThread newThread(ForkJoinPool
>>> pool) {
>>> 1108:
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
Roger Riggs has updated the pull request incrementally with one additional
commit since th
On Fri, 15 Nov 2024 07:23:23 GMT, Alan Bateman wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> src/java.base/share/classes
On Fri, 15 Nov 2024 13:30:34 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
>>
>>> 1106: implements ForkJoinWorkerThreadFactory {
>>> 1107: public final ForkJoinWorkerThread newThread(ForkJoinPool
>>> pool) {
>>> 1108:
On Fri, 15 Nov 2024 13:41:09 GMT, Doug Lea wrote:
>> This class is currently meaningless, perhaps it should be carefully removed
>> and the documentation for `priviledgedCallable` should be updated.
>
> Deleting it would also mean removing or modifying a bunch of j.u./tck tests.
> Perhaps depre
On Fri, 15 Nov 2024 10:16:00 GMT, Glavo wrote:
>> src/java.base/share/classes/java/util/concurrent/Executors.java line 556:
>>
>>> 554: * A callable that runs under established access control settings.
>>> 555: */
>>> 556: private static final class PrivilegedCallable implements
>
On Fri, 15 Nov 2024 07:36:37 GMT, Alan Bateman wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> src/java.base/share/classes
On Fri, 15 Nov 2024 07:25:10 GMT, Alan Bateman wrote:
>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
>> common thread pool.
>>
>> A careful review is requested.
>
> src/java.base/share/classes
On Thu, 14 Nov 2024 20:45:49 GMT, Roger Riggs wrote:
> Refactored to remove use of doPrivileged() and use of SecurityManager.
> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a
> common thread pool.
>
> A careful review is requested.
I did a pass over this. Most of it i
Refactored to remove use of doPrivileged() and use of SecurityManager.
The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a common
thread pool.
A careful review is requested.
-
Commit messages:
- Drop mention of permissions
- 8344197: SM cleanup in java.util.co
18 matches
Mail list logo
