Re: RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

2024-11-13 Thread Andrey Turbanov
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote: > Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is > fully initialized in `` block. > It means we can replace legacy synchronized `Hashtable` with immutable set. I run `com/sun/jndi` tests on my win x64. All green.

Re: RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

2024-11-12 Thread Daniel Fuchs
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote: > Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is > fully initialized in `` block. > It means we can replace legacy synchronized `Hashtable` with immutable set. Thanks for running the tests @AlekseiEfimov ---

Re: RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

2024-11-12 Thread Aleksei Efimov
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote: > Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is > fully initialized in `` block. > It means we can replace legacy synchronized `Hashtable` with immutable set. The changes look good to me. Also, I've launched exi

Re: RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

2024-11-12 Thread Daniel Fuchs
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote: > Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is > fully initialized in `` block. > It means we can replace legacy synchronized `Hashtable` with immutable set. Looks worthwhile and reasonable. What tests did you

RFR: 8344023: Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs

2024-11-12 Thread Andrey Turbanov
Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is fully initialized in `` block. It means we can replace legacy synchronized `Hashtable` with immutable set. - Commit messages: - [PATCH] Unnecessary Hashtable usage in LdapClient.defaultBinaryAttrs Changes: ht