Re: RFR: 8343876: Enhancements to jpackage test lib [v5]

2024-11-15 Thread Alexander Matveev
On Fri, 15 Nov 2024 18:34:07 GMT, Alexey Semenyuk wrote: >> Make jpackage test lib more practical. List of changes: >> >> Support multiple args and var args in `@Parameter` annotation: >> >> @Test >> @Parameter({"12", "foo"}) >> @Parameter({"-89", "bar", "more"}) >> @Parameter({"-89", "bar", "m

Re: RFR: 8343876: Enhancements to jpackage test lib [v5]

2024-11-15 Thread Alexander Matveev
On Fri, 15 Nov 2024 14:53:18 GMT, Alexey Semenyuk wrote: >> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestMethodSupplier.java >> line 142: >> >>> 140: throw ex; >>> 141: } >>> 142: } >> >> Maybe move this code into `switch` statement under `default`?

Re: RFR: 8343876: Enhancements to jpackage test lib [v5]

2024-11-15 Thread Alexey Semenyuk
> Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "moore"}) > public void testVarArg(int a, String b, String ..

Re: RFR: 8343876: Enhancements to jpackage test lib [v4]

2024-11-15 Thread Alexey Semenyuk
> Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "moore"}) > public void testVarArg(int a, String b, String ..

Re: RFR: 8343876: Enhancements to jpackage test lib [v3]

2024-11-15 Thread Alexey Semenyuk
On Fri, 15 Nov 2024 01:20:34 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove redundant "method.setAccessible(true);" calls > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Tes

Re: RFR: 8343876: Enhancements to jpackage test lib [v3]

2024-11-15 Thread Alexey Semenyuk
> Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "moore"}) > public void testVarArg(int a, String b, String ..

Re: RFR: 8343876: Enhancements to jpackage test lib [v2]

2024-11-15 Thread Alexey Semenyuk
On Fri, 15 Nov 2024 01:12:00 GMT, Alexander Matveev wrote: > Maybe move this code into switch statement under default? Can't use "null" in the switch. > should we use TypeStatus.UNKNOWN instead of null? To deal with `TypeStatus.UNKNOWN` and `null`? Besides of that what is the semantics of `T

Re: RFR: 8343876: Enhancements to jpackage test lib

2024-11-15 Thread Alexey Semenyuk
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote: > Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "mo

Re: RFR: 8343876: Enhancements to jpackage test lib [v2]

2024-11-15 Thread Alexey Semenyuk
> Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "moore"}) > public void testVarArg(int a, String b, String ..

Re: RFR: 8343876: Enhancements to jpackage test lib

2024-11-15 Thread Alexey Semenyuk
On Fri, 15 Nov 2024 00:02:29 GMT, Alexander Matveev wrote: >> Make jpackage test lib more practical. List of changes: >> >> Support multiple args and var args in `@Parameter` annotation: >> >> @Test >> @Parameter({"12", "foo"}) >> @Parameter({"-89", "bar", "more"}) >> @Parameter({"-89", "bar",

Re: RFR: 8343876: Enhancements to jpackage test lib

2024-11-14 Thread Alexander Matveev
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote: > Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "mo

Re: RFR: 8343876: Enhancements to jpackage test lib

2024-11-14 Thread Alexander Matveev
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote: > Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "mo

Re: RFR: 8343876: Enhancements to jpackage test lib

2024-11-14 Thread Alexey Semenyuk
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote: > Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "mo

RFR: 8343876: Enhancements to jpackage test lib

2024-11-14 Thread Alexey Semenyuk
Make jpackage test lib more practical. List of changes: Support multiple args and var args in `@Parameter` annotation: @Test @Parameter({"12", "foo"}) @Parameter({"-89", "bar", "more"}) @Parameter({"-89", "bar", "more", "moore"}) public void testVarArg(int a, String b, String ... other) {} Full