Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v10]

2025-05-13 Thread Raffaello Giulietti
On Tue, 13 May 2025 03:58:44 GMT, Joe Darcy wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Addressed reviewer comments. > > src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1878: > >

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v10]

2025-05-12 Thread Joe Darcy
On Sat, 10 May 2025 10:08:39 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Addressed reviewer comments. Marked as reviewed by darcy (Reviewer).

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v10]

2025-05-10 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Addressed reviewer comments. - Changes: - all: https://git.openjdk.org/jdk/pull/22737/files - new: https://git.openjdk.org/jd

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v9]

2025-05-10 Thread Raffaello Giulietti
On Fri, 9 May 2025 22:58:19 GMT, Chen Liang wrote: >> Raffaello Giulietti has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 14 >> additional commi

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 22:48:34 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v8]

2025-05-09 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v9]

2025-05-09 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-07 Thread Joe Darcy
On Fri, 2 May 2025 15:28:39 GMT, Raffaello Giulietti wrote: >> If I understand correctly, we are talking about several (primitive) array >> type fields having a `@Stable` annotation, in a single class, right? So we >> aren't really talking about levels? >> If so, given what `@Stable` is docume

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Raffaello Giulietti
On Fri, 2 May 2025 14:21:54 GMT, Jaikiran Pai wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make some static arrays @Stable. > > If I understand correctly, we are talking about several (primitive) array >

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Jaikiran Pai
On Fri, 2 May 2025 13:34:02 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Make some static arrays @Stable. If I understand correctly, we are ta

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Raffaello Giulietti
On Fri, 2 May 2025 13:34:02 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Make some static arrays @Stable. I'm not worried if C2 cannot optimiz

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 13:40:14 GMT, Shaojin Wen wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make some static arrays @Stable. > > Q_MIN -> E_MIN -> E_MAX -> W -> P Five layers of Stable, I don't know if C2

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Raffaello Giulietti
On Fri, 2 May 2025 13:40:14 GMT, Shaojin Wen wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make some static arrays @Stable. > > Q_MIN -> E_MIN -> E_MAX -> W -> P Five layers of Stable, I don't know if C2

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 13:34:02 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Make some static arrays @Stable. Q_MIN -> E_MIN -> E_MAX -> W -> P Fi

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v7]

2025-05-02 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Make some static arrays @Stable. - Changes: - all: https://git.openjdk.org/jdk/pull/22737/files - new: https://git.openjdk.or

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v6]

2025-05-02 Thread Raffaello Giulietti
On Fri, 2 May 2025 12:00:13 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v6]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 12:00:13 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v6]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 12:00:13 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v6]

2025-05-02 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v5]

2025-05-02 Thread Shaojin Wen
On Thu, 9 Jan 2025 10:55:16 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v5]

2025-04-29 Thread Raffaello Giulietti
On Thu, 9 Jan 2025 10:55:16 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v5]

2025-03-11 Thread Raffaello Giulietti
On Thu, 9 Jan 2025 10:55:16 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v5]

2025-01-09 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revisio

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v4]

2024-12-16 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Redacted comments. - Changes: - all: https://git.openjdk.org/jdk/pull/22737/files - new: https://git.openjdk.org/jdk/pull/227

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v3]

2024-12-16 Thread Raffaello Giulietti
On Sun, 15 Dec 2024 21:57:12 GMT, j3graham wrote: >> Raffaello Giulietti has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additional comm

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v3]

2024-12-15 Thread j3graham
On Fri, 13 Dec 2024 16:06:53 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. Th

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v3]

2024-12-13 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v2]

2024-12-13 Thread Raffaello Giulietti
> See the JBS bug for some details. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Removed repeated comment. - Changes: - all: https://git.openjdk.org/jdk/pull/22737/files - new: https://git.openjdk.org/jdk/p

RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal

2024-12-13 Thread Raffaello Giulietti
See the JBS bug for some details. - Commit messages: - Refactoring some code and comments. - 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal Changes: https://git.openjdk.org/jdk/pull/22737/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22737&range=00 I