Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-14 Thread Viktor Klang
On Tue, 12 Nov 2024 19:31:21 GMT, kabutz wrote: >>> @kabutz Let me know how you want to proceed. 👍 >> >> 've made the changes and sent another PR to the branch holding the changes. >> Hope that's the right way of doing it... > >> @kabutz The update for CSLM is based on @DougLea's proposal on th

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream [v3]

2024-11-13 Thread duke
On Tue, 12 Nov 2024 16:12:36 GMT, kabutz wrote: >> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to >> the head, which has item == null, rather than to the first element. The >> trySplit() method no longer worked, and always returned null. Therefore, >> parallel strea

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream [v3]

2024-11-13 Thread Viktor Klang
On Tue, 12 Nov 2024 16:12:36 GMT, kabutz wrote: >> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to >> the head, which has item == null, rather than to the first element. The >> trySplit() method no longer worked, and always returned null. Therefore, >> parallel strea

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread Viktor Klang
On Tue, 12 Nov 2024 19:31:21 GMT, kabutz wrote: >>> @kabutz Let me know how you want to proceed. 👍 >> >> 've made the changes and sent another PR to the branch holding the changes. >> Hope that's the right way of doing it... > >> @kabutz The update for CSLM is based on @DougLea's proposal on th

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread kabutz
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote: >>> @kabutz I think @DougLea identified some potential edge-cases with the >>> proposed solution, so I added his suggested diff to the JBS Issue for >>> reference. >> >> Indeed, I didn't check what happens when we create a spliterator on an empty

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream [v3]

2024-11-12 Thread kabutz
> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to > the head, which has item == null, rather than to the first element. The > trySplit() method no longer worked, and always returned null. Therefore, > parallel streams have not worked for ConcurrentSkipListMap and > Co

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread Viktor Klang
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote: >>> @kabutz I think @DougLea identified some potential edge-cases with the >>> proposed solution, so I added his suggested diff to the JBS Issue for >>> reference. >> >> Indeed, I didn't check what happens when we create a spliterator on an empty

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream [v2]

2024-11-12 Thread kabutz
> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to > the head, which has item == null, rather than to the first element. The > trySplit() method no longer worked, and always returned null. Therefore, > parallel streams have not worked for ConcurrentSkipListMap and > Co

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread Viktor Klang
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote: >>> @kabutz I think @DougLea identified some potential edge-cases with the >>> proposed solution, so I added his suggested diff to the JBS Issue for >>> reference. >> >> Indeed, I didn't check what happens when we create a spliterator on an empty

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread Viktor Klang
On Tue, 12 Nov 2024 15:41:36 GMT, kabutz wrote: >>> @kabutz I think @DougLea identified some potential edge-cases with the >>> proposed solution, so I added his suggested diff to the JBS Issue for >>> reference. >> >> Indeed, I didn't check what happens when we create a spliterator on an empty

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread kabutz
On Mon, 4 Nov 2024 16:14:35 GMT, kabutz wrote: >> Sure, where should I add that test? > >> @kabutz I think @DougLea identified some potential edge-cases with the >> proposed solution, so I added his suggested diff to the JBS Issue for >> reference. > > Indeed, I didn't check what happens when

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-12 Thread Viktor Klang
On Mon, 4 Nov 2024 16:14:35 GMT, kabutz wrote: >> Sure, where should I add that test? > >> @kabutz I think @DougLea identified some potential edge-cases with the >> proposed solution, so I added his suggested diff to the JBS Issue for >> reference. > > Indeed, I didn't check what happens when

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-04 Thread kabutz
On Fri, 1 Nov 2024 10:58:09 GMT, kabutz wrote: >> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to >> the head, which has item == null, rather than to the first element. The >> trySplit() method no longer worked, and always returned null. Therefore, >> parallel stream

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-04 Thread Viktor Klang
On Fri, 1 Nov 2024 10:58:09 GMT, kabutz wrote: >> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to >> the head, which has item == null, rather than to the first element. The >> trySplit() method no longer worked, and always returned null. Therefore, >> parallel stream

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-01 Thread Viktor Klang
On Fri, 1 Nov 2024 10:58:09 GMT, kabutz wrote: >> Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to >> the head, which has item == null, rather than to the first element. The >> trySplit() method no longer worked, and always returned null. Therefore, >> parallel stream

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-01 Thread kabutz
On Fri, 1 Nov 2024 10:13:15 GMT, kabutz wrote: > Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to > the head, which has item == null, rather than to the first element. The > trySplit() method no longer worked, and always returned null. Therefore, > parallel streams ha

Re: RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-01 Thread Viktor Klang
On Fri, 1 Nov 2024 10:13:15 GMT, kabutz wrote: > Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to > the head, which has item == null, rather than to the first element. The > trySplit() method no longer worked, and always returned null. Therefore, > parallel streams ha

RFR: 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream

2024-11-01 Thread kabutz
Since Java 10, spliterators for the ConcurrentSkipListMap were pointing to the head, which has item == null, rather than to the first element. The trySplit() method no longer worked, and always returned null. Therefore, parallel streams have not worked for ConcurrentSkipListMap and ConcurrentSki