On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21940#pullrequestreview-2422
Use internal jdk API instead of parsing JVM properties where appropriate in
jpackage tests
-
Commit messages:
- 8343396: Use OperatingSystem, Architecture, and OSVersion in jpackage tests
Changes: https://git.openjdk.org/jdk/pull/21940/files
Webrev: https://webrevs.openjdk.org/?r
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/21940#issuecomment-2462120368
On Wed, 6 Nov 2024 21:42:36 GMT, Alexey Semenyuk wrote:
> Use internal jdk API instead of parsing JVM properties where appropriate in
> jpackage tests
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21940#pullrequestreview-2421175432
