Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2025-01-06 Thread Brian Burkhalter
On Tue, 24 Dec 2024 11:46:44 GMT, Taizo Kurashige wrote: > After applying the patch you provided, I confirmed that the test using the > mounted ISO file passes. I'm sorry I haven't been able to see the results of > the physical CD drive test myself, but I think I'll commit this patch. Thank >

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-24 Thread Taizo Kurashige
On Wed, 18 Dec 2024 23:02:34 GMT, Brian Burkhalter wrote: > So I don't see any difference between a physical drive and a mounted ISO file > with respect to this test. I understood that the test fails on both the physical CD drive and the mounted ISO file. In my environment, testing with a mou

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-20 Thread Brian Burkhalter
On Fri, 13 Dec 2024 10:10:16 GMT, Taizo Kurashige wrote: >> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use >> Cygwin’s `df` to get the size for comparison if the test target drive is a >> CD-ROM drive. >> >> As described in JDK-8343342, GetDiskSpaceInformationW ca

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-18 Thread Brian Burkhalter
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote: > Could you tell me what the result would be if you tested using a virtual > drive with the iso file mounted instead of a physical CD drive and disk? I mounted an ISO file on `D:`. Command line execution of `df` in Cygwin: $ df D:\\ File

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-18 Thread Brian Burkhalter
On Wed, 18 Dec 2024 00:30:37 GMT, Brian Burkhalter wrote: > Also, can you tell me the version of Cygwin (output of “uname -r”)? $ uname -r 3.4.8-1.x86_64 - PR Comment: https://git.openjdk.org/jdk/pull/21799#issuecomment-2552410033

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-17 Thread Brian Burkhalter
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote: > I'm sorry, but I would like to know what the output looks like when you run > the df command on a virtual drive with the iso file mounted. I can investigate that tomorrow, Pacific Time. As I recall, an earlier version _did_ work with t

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-17 Thread Taizo Kurashige
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote: > It fails for me on a Windows 11 laptop with an external CD drive with a CD > inserted. On Cygwin the df command gives: Could you tell me what the result would be if you tested using a virtual drive with the iso file mounted instead of

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-13 Thread Brian Burkhalter
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote: > Perhaps the output of `df` is not being parsed correctly? Actually I am getting df: 'D:': No such file or directory as the first line returned by the process that runs `df` when I run the test in Cygwin. On the command line this does

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-13 Thread Brian Burkhalter
On Fri, 13 Dec 2024 10:10:16 GMT, Taizo Kurashige wrote: >> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use >> Cygwin’s `df` to get the size for comparison if the test target drive is a >> CD-ROM drive. >> >> As described in JDK-8343342, GetDiskSpaceInformationW ca

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-13 Thread Taizo Kurashige
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use > Cygwin’s `df` to get the size for comparison if the test target drive is a > CD-ROM drive. > > As described in JDK-8343342, GetDiskSpaceInformationW can't get information > about the size of the CD-ROM drive. > Ge