On Fri, 13 Dec 2024 10:10:53 GMT, Taizo Kurashige wrote:
>> test/jdk/java/io/File/GetXSpace.java line 415:
>>
>>> 413: private static native boolean isCDDrive(String root);
>>> 414:
>>> 415: private static long[] getCDDriveSpace(String root) throws
>>> IOException {
>>
>> Why not pass
On Fri, 13 Dec 2024 10:10:22 GMT, Taizo Kurashige wrote:
>>> The native `GetXSpace` method needs to be defined on all platforms
>>
>> This change fixes that problem:
>>
>> --- a/test/jdk/java/io/File/libGetXSpace.c
>> +++ b/test/jdk/java/io/File/libGetXSpace.c
>> @@ -160,11 +160,11 @@ Java_GetX
On Wed, 11 Dec 2024 18:45:43 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/libGetXSpace.c line 165:
>>
>>> 163: #ifdef WINDOWS
>>> 164: JNIEXPORT jboolean JNICALL
>>> 165: Java_GetXSpace_isCDDrive
>>
>> The native `GetXSpace` method needs to be defined on all platforms,
>> otherwise we
On Thu, 12 Dec 2024 23:20:51 GMT, Brian Burkhalter wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add ifdef WINDOWS
>
> test/jdk/java/io/File/GetXSpace.java line 415:
>
>> 413: private static native boolea
On Mon, 9 Dec 2024 10:55:13 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
On Wed, 11 Dec 2024 18:40:41 GMT, Brian Burkhalter wrote:
> The native `GetXSpace` method needs to be defined on all platforms
This change fixes that problem:
--- a/test/jdk/java/io/File/libGetXSpace.c
+++ b/test/jdk/java/io/File/libGetXSpace.c
@@ -160,11 +160,11 @@ Java_GetXSpace_getSpace0
On Mon, 9 Dec 2024 10:55:13 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
