Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Brian Burkhalter
On Wed, 13 Nov 2024 19:42:29 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof > > src/java.base/share/classes/java/io/Buffer

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Alan Bateman
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote: >> Uses of `InternalLock` are removed and `synchronized` is reinstated. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8343039: Remove JavaIOPrint{Stream,Writer

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Brian Burkhalter
On Wed, 13 Nov 2024 19:57:39 GMT, Alan Bateman wrote: > [...] it's good that Chen is reviewing too as would be too easy to introduce > a bug with this refactor. Definitely on both counts. > src/java.base/share/classes/java/io/BufferedInputStream.java line 242: > >> 240: initialSize =

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Alan Bateman
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote: >> Uses of `InternalLock` are removed and `synchronized` is reinstated. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8343039: Remove JavaIOPrint{Stream,Writer

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Chen Liang
On Wed, 13 Nov 2024 07:15:15 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/BufferedOutputStream.java line 88: >> >>> 86: } >>> 87: >>> 88: this.buf = new byte[initialSize]; // resizable if initialSize < >>> maxSize >> >> Same remark as for BIS. >> >> Also th

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Alan Bateman
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote: >> Uses of `InternalLock` are removed and `synchronized` is reinstated. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8343039: Remove JavaIOPrint{Stream,Writer

Re: RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v3]

2024-11-13 Thread Brian Burkhalter
> Uses of `InternalLock` are removed and `synchronized` is reinstated. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof - Changes: - all: https://