Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property [v3]

2024-12-03 Thread Roger Riggs
On Tue, 3 Dec 2024 19:55:58 GMT, Joe Wang wrote: >> Disables XSLT and XPath Extension Functions by default, setting >> jdk.xml.enableExtensionFunctions to false. >> >> Adjusted tests accordingly. > > Joe Wang has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property [v3]

2024-12-03 Thread Joe Wang
On Tue, 3 Dec 2024 17:23:40 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix error message and inline windows check > > src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Err

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property [v3]

2024-12-03 Thread Joe Wang
> Disables XSLT and XPath Extension Functions by default, setting > jdk.xml.enableExtensionFunctions to false. > > Adjusted tests accordingly. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: fix error message and inline windows check -

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property [v2]

2024-12-03 Thread Joe Wang
On Tue, 3 Dec 2024 11:42:41 GMT, Lance Andersen wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> uncomment a test in XSLTFunctionsTest > > test/jaxp/javax/xml/jaxp/unittest/transform/XSLTFunctionsTest.java line 162: >

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property [v2]

2024-12-03 Thread Joe Wang
> Disables XSLT and XPath Extension Functions by default, setting > jdk.xml.enableExtensionFunctions to false. > > Adjusted tests accordingly. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: uncomment a test in XSLTFunctionsTest --

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property

2024-12-03 Thread Roger Riggs
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote: > Disables XSLT and XPath Extension Functions by default, setting > jdk.xml.enableExtensionFunctions to false. > > Adjusted tests accordingly. src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java line 28

Re: RFR: 8343001: Adjust XSLT and XPath Extension Function Property

2024-12-03 Thread Lance Andersen
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote: > Disables XSLT and XPath Extension Functions by default, setting > jdk.xml.enableExtensionFunctions to false. > > Adjusted tests accordingly. Overall Looks good Joe please see the comment below test/jaxp/javax/xml/jaxp/unittest/transform/XSLT

RFR: 8343001: Adjust XSLT and XPath Extension Function Property

2024-12-02 Thread Joe Wang
Disables XSLT and XPath Extension Functions by default, setting jdk.xml.enableExtensionFunctions to false. Adjusted tests accordingly. - Commit messages: - 8343001: Adjust XSLT and XPath Extension Function Property Changes: https://git.openjdk.org/jdk/pull/22504/files Webrev: ht