Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-05 Thread Naoto Sato
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-05 Thread Jan Lahoda
On Tue, 5 Nov 2024 09:48:29 GMT, vulinh64 wrote: > My question (please don't bash me, I am new): Any chance we can set the > encoding of console? I tested on Java 23 (Windows) and the encoding is > `windows-1252` so it will not display unicode characters correctly. I believe that after https:/

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-05 Thread vulinh64
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-03 Thread Jaikiran Pai
On Wed, 30 Oct 2024 12:25:34 GMT, Jan Lahoda wrote: >> src/java.base/share/classes/java/io/Console.java line 184: >> >>> 182: */ >>> 183: @PreviewFeature(feature = PreviewFeature.Feature.IMPLICIT_CLASSES) >>> 184: public Console println() { >> >> Hello Jan, with the introduction of

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-03 Thread Jaikiran Pai
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-01 Thread Adam Sotona
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-30 Thread Jan Lahoda
On Wed, 30 Oct 2024 09:07:47 GMT, Evemose wrote: >> src/java.base/share/classes/java/io/Console.java line 240: >> >>> 238: * if an end of stream has been reached without having >>> read >>> 239: * any characters. >>> 240: * >> >> Should we specify (both here an

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-30 Thread Jan Lahoda
On Wed, 30 Oct 2024 08:17:02 GMT, Jaikiran Pai wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing test for Console.readln/readLine, ensuring the proper methods are >> called. > > src/java.base/share/classes/java

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-30 Thread Evemose
On Wed, 30 Oct 2024 08:27:23 GMT, Jaikiran Pai wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing test for Console.readln/readLine, ensuring the proper methods are >> called. > > src/java.base/share/classes/java

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-30 Thread Jaikiran Pai
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-30 Thread Jaikiran Pai
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-10-29 Thread Jan Lahoda
> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, > with the (hopefully) obvious semantics, plus the corresponding wiring to make > those work. This may become part of JEP 495: > https://openjdk.org/jeps/495 Jan Lahoda has updated the pull request incrementally with on