On Wed, 30 Oct 2024 22:07:34 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Tue, 29 Oct 2024 16:22:47 GMT, Aleksey Shipilev wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust comment.
>
> src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 92:
>
>> 90:
On Wed, 30 Oct 2024 22:07:34 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Wed, 30 Oct 2024 22:07:34 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Tue, 29 Oct 2024 16:22:47 GMT, Aleksey Shipilev wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust comment.
>
> src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 92:
>
>> 90:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
>
On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Mon, 28 Oct 2024 10:54:29 GMT, Alan Bateman wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust comment.
>
> src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 58:
>
>> 56:
>> 57:
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Mon, 28 Oct 2024 10:54:29 GMT, Alan Bateman wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjust comment.
>
> src/java.base/share/classes/jdk/internal/module/ModuleLoaderMap.java line 58:
>
>> 56:
>> 57:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
>
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
Moved from
https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
Please review the fix that uses String type for the mapped value in
ModuleLoaderMap.Mapper map (Map). Please see details in
https://bugs.openjdk.org/browse/JDK-8342642, thanks.
Existing comme
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
Jiangli Zhou has updated the pull request incrementally with 109 additional
commits since the last revision:
-
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Fri, 25 Oct 2024 20:53:09 GMT, Jiangli Zhou wrote:
> There is an issue from my last push. It includes unintended merged changes
> from head. It's probably because I did a cherrypick for my fix when creating
> the initial PR. Let me close this PR and create a new one. I'll link all
> existin
On Fri, 25 Oct 2024 20:11:36 GMT, Jiangli Zhou wrote:
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details in
>> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
>
> Jiangli Zhou has updated the pull request increment
On Fri, 25 Oct 2024 10:45:00 GMT, Aleksey Shipilev wrote:
> > In that sense, I think we don't have a risk of potentially with
> > `used_Integer > IntegerCache.high`. The idea described in Ioi's comment
> > above (also brought up by Aleksey Shipilev separately during premain
> > meeting) could
On Thu, 24 Oct 2024 20:16:59 GMT, Jiangli Zhou wrote:
> The conclusion was it's better to avoid using boxed Integer and go with
> String in ModuleLoaderMap.Mapper.
Okay, you'll need to rename the fields and Mapper's description will need to be
updated as explains why a boxed value was used.
-
On Thu, 24 Oct 2024 21:20:57 GMT, Jiangli Zhou wrote:
> In that sense, I think we don't have a risk of potentially with `used_Integer
> > IntegerCache.high`. The idea described in Ioi's comment above (also brought
> up by Aleksey Shipilev separately during premain meeting) could be sufficient.
On Wed, 23 Oct 2024 22:14:13 GMT, Jiangli Zhou wrote:
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
I brought up this issue in today's Leyden/premain meeting
On Wed, 23 Oct 2024 22:14:13 GMT, Jiangli Zhou wrote:
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
@iklam Would it be possible to comment on this? If the s
On Thu, 24 Oct 2024 05:51:38 GMT, Ioi Lam wrote:
>> @iklam Would it be possible to comment on this? If the system properties to
>> configure the range of integer cache are set at runtime, does it just not
>> use this archived object graph? I'm wondering if it should disable CDS?
>
>> @iklam Wo
On Thu, 24 Oct 2024 05:51:38 GMT, Ioi Lam wrote:
> > @iklam Would it be possible to comment on this? If the system properties to
> > configure the range of integer cache are set at runtime, does it just not
> > use this archived object graph? I'm wondering if it should disable CDS?
>
> A bette
On Thu, 24 Oct 2024 05:05:55 GMT, Alan Bateman wrote:
> @iklam Would it be possible to comment on this? If the system properties to
> configure the range of integer cache are set at runtime, does it just not use
> this archived object graph? I'm wondering if it should disable CDS?
A better fix
Please review the fix that uses String type for the mapped value in
ModuleLoaderMap.Mapper map (Map). Please see details in
https://bugs.openjdk.org/browse/JDK-8342642, thanks.
-
Commit messages:
- Use String instances as the loader indexes in ModuleLoaderMap.Mapper map.
Changes:
29 matches
Mail list logo
