Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Chen Liang
On Thu, 21 Nov 2024 10:52:56 GMT, Adam Sotona wrote: >> Chen Liang has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - typo >> - More cleanup >> - Remove a few confusions around bad modeling, some missing exceptions, >> also the labell

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-20 Thread Chen Liang
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-20 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. > > API Diff: > https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html > Javadoc: > https://cr.openjdk.org/~liach/javadoc/cf-inst