Re: RFR: 8341957: Add test for URLClassLoader loading invalid class with mismatching CRC32

2024-10-13 Thread Eirik Bjørsnøs
On Sun, 13 Oct 2024 07:07:52 GMT, Jaikiran Pai wrote: > .. is merely an implementation detail (which should be free to change any > time). I think asserting this internal detail through a test case isn't > necessary. Thanks Jai. Sure, this test asserts invariants of the implementation, not in

Re: RFR: 8341957: Add test for URLClassLoader loading invalid class with mismatching CRC32

2024-10-13 Thread Jaikiran Pai
On Fri, 11 Oct 2024 11:46:40 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds test coverage for the case where > `URLClassLoader.defineClass` fails with a `ClassFormatError` _and_ the CRC32 > checksum of the class file byte array did not match the CRC32 value stated in > the JAR f

RFR: 8341957: Add test for URLClassLoader loading invalid class with mismatching CRC32

2024-10-11 Thread Eirik Bjørsnøs
Please review this PR which adds test coverage for the case where `URLClassLoader.defineClass` fails with a `ClassFormatError` _and_ the CRC32 checksum of the class file byte array did not match the CRC32 value stated in the JAR file's CEN header. In such cases, an `IOException` with the messag