Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Justin Lu
On Wed, 20 Nov 2024 18:20:04 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Naoto's comments > > src/java.base/share/classes/java/util/Locale.java line 1256: > >> 1254: >> 1255: /** >> 1

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/Locale.java line 144: >> >>> 142: * each indicating its own semantics, these values should be ordered >>> 143: * by importance, with most important first, separated by >>> 144: * underscore('_').

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-19 Thread Justin Lu
On Tue, 19 Nov 2024 20:30:11 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Naoto's comments > > src/java.base/share/classes/java/util/Locale.java line 144: > >> 142: * each indicating its

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-19 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a