Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-20 Thread Naoto Sato
On Tue, 19 Nov 2024 07:58:22 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-20 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-19 Thread Justin Lu
On Tue, 19 Nov 2024 19:46:42 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Chen's review; make other similar changes > > src/java.base/share/classes/java/util/Locale.java line 89: > >> 87:

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-18 Thread Justin Lu
On Mon, 18 Nov 2024 20:37:27 GMT, Chen Liang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Chen's review; make other similar changes > > src/java.base/share/classes/java/util/Locale.java line 94: > >> 92: