Re: RFR: 8341923: java.util.Locale class specification improvements [v5]

2024-12-04 Thread Justin Lu
On Tue, 3 Dec 2024 02:29:16 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this change

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-12-02 Thread Joe Darcy
On Tue, 3 Dec 2024 02:26:03 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/Locale.java line 76: >> >>> 74: * or cultural region. An API that requires a {@code Locale} to perform >>> 75: * its task is locale-sensitive and uses the {@code Locale} >>> 76: * to tailor information

Re: RFR: 8341923: java.util.Locale class specification improvements [v5]

2024-12-02 Thread Chen Liang
On Tue, 3 Dec 2024 02:29:16 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this change

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-12-02 Thread Justin Lu
On Mon, 2 Dec 2024 23:00:20 GMT, Joe Darcy wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review > > src/java.base/share/classes/java/util/Locale.java line 76: > >> 74: * or cultural region. An API that req

Re: RFR: 8341923: java.util.Locale class specification improvements [v5]

2024-12-02 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-12-02 Thread Joe Darcy
On Thu, 21 Nov 2024 06:53:58 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-11-21 Thread Naoto Sato
On Thu, 21 Nov 2024 06:53:58 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Justin Lu
On Wed, 20 Nov 2024 18:20:04 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Naoto's comments > > src/java.base/share/classes/java/util/Locale.java line 1256: > >> 1254: >> 1255: /** >> 1

Re: RFR: 8341923: java.util.Locale class specification improvements [v4]

2024-11-20 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-20 Thread Naoto Sato
On Tue, 19 Nov 2024 07:58:22 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/Locale.java line 144: >> >>> 142: * each indicating its own semantics, these values should be ordered >>> 143: * by importance, with most important first, separated by >>> 144: * underscore('_').

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu wrote: >> Please review this PR and corresponding CSR which includes a wide range of >> specification improvements for java.util.Locale. See the CSR for further >> detail. Other changes/suggestions are welcomed to be included as part of >> this chang

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-20 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-19 Thread Justin Lu
On Tue, 19 Nov 2024 20:30:11 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Naoto's comments > > src/java.base/share/classes/java/util/Locale.java line 144: > >> 142: * each indicating its

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-19 Thread Justin Lu
On Tue, 19 Nov 2024 19:46:42 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Chen's review; make other similar changes > > src/java.base/share/classes/java/util/Locale.java line 89: > >> 87:

Re: RFR: 8341923: java.util.Locale class specification improvements [v3]

2024-11-19 Thread Justin Lu
> Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. > > APIDiff: > https://cr.openjdk.org/~jlu/8341923_a

Re: RFR: 8341923: java.util.Locale class specification improvements [v2]

2024-11-18 Thread Justin Lu
On Mon, 18 Nov 2024 20:37:27 GMT, Chen Liang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address Chen's review; make other similar changes > > src/java.base/share/classes/java/util/Locale.java line 94: > >> 92:

Re: RFR: 8341923: java.util.Locale class specification improvements

2024-11-18 Thread Chen Liang
On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu wrote: > Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. A

Re: RFR: 8341923: java.util.Locale class specification improvements

2024-11-18 Thread Chen Liang
On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu wrote: > Please review this PR and corresponding CSR which includes a wide range of > specification improvements for java.util.Locale. See the CSR for further > detail. Other changes/suggestions are welcomed to be included as part of this > change. A

RFR: 8341923: java.util.Locale class specification improvements

2024-11-17 Thread Justin Lu
Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change. Alternatively the diffs can be viewed on the API diff link att