Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Justin Lu
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Naoto Sato
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Roger Riggs
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Lance Andersen
On Thu, 10 Oct 2024 11:40:27 GMT, Alan Bateman wrote: > > were left out from the commit for the PR but are listed in the JBS issue so > > it would be great to include the updates as part of this PR or explain why > > they were excluded if it was intentional > > The original bug report has seve

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Lance Andersen
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Alan Bateman
On Thu, 10 Oct 2024 11:07:19 GMT, Lance Andersen wrote: > were left out from the commit for the PR but are listed in the JBS issue so > it would be great to include the updates as part of this PR or explain why > they were excluded if it was intentional The original bug report has several fals

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Lance Andersen
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Daniel Fuchs
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-10 Thread Jaikiran Pai
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

Re: RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-09 Thread Brian Burkhalter
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote: > Please review this PR which fixes incorrect usage of `jthrowable > ExceptionOccurred(JNIEnv *env)` within _java.base_. > > This corrects instances where the return value is being treated as a boolean. > Such occurrences are replaced with `jbo

RFR: 8341789: Fix ExceptionOccurred in java.base

2024-10-09 Thread Justin Lu
Please review this PR which fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)` within _java.base_. This corrects instances where the return value is being treated as a boolean. Such occurrences are replaced with `jboolean ExceptionCheck(JNIEnv *env)`. - Commit mes