Re: RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN [v2]

2024-10-07 Thread Lance Andersen
On Mon, 7 Oct 2024 12:16:15 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we clean up iteration and validation >> logic in `ZipFile.Source::initCEN` and some related methods to use a simpler >> and more consistent style: >> >> * The main loop in `ZipFile.Source::initCEN` c

Re: RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN [v2]

2024-10-07 Thread Eirik Bjørsnøs
On Mon, 7 Oct 2024 11:35:00 GMT, Claes Redestad wrote: >> Eirik Bjørsnøs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Mark this resource hungry test manual >> - For the benefit of the interpreter, extract loop predicate into a loca

Re: RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN [v2]

2024-10-07 Thread Eirik Bjørsnøs
> Please review this PR which suggests we clean up iteration and validation > logic in `ZipFile.Source::initCEN` and some related methods to use a simpler > and more consistent style: > > * The main loop in `ZipFile.Source::initCEN` currently updates two iteration > variables (`pos` and `entryP

Re: RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN

2024-10-07 Thread Claes Redestad
On Sun, 6 Oct 2024 16:42:15 GMT, Eirik Bjørsnøs wrote: > Please review this PR which suggests we clean up iteration and validation > logic in `ZipFile.Source::initCEN` and some related methods to use a simpler > and more consistent style: > > * The main loop in `ZipFile.Source::initCEN` curren

RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN

2024-10-07 Thread Eirik Bjørsnøs
Please review this PR which suggests we clean up iteration and validation logic in `ZipFile.Source::initCEN` and some related methods to use a simpler and more consistent style: * The main loop in `ZipFile.Source::initCEN` currently updates two iteration variables (`pos` and `entryPos`), where