On Sun, 6 Oct 2024 09:15:58 GMT, SendaoYan wrote:
> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
> mode.
Okey, I will create a new PR to the test from the problem list and use
`@requires` instead. Thanks for the correction.
-
PR Comment: https://git.
On Mon, 7 Oct 2024 14:53:48 GMT, SendaoYan wrote:
>> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
>> mode.
>
> Thanks for the review.
Hello @sendaoYan, I noticed this PR today. For tests that we want to exclude
from Xcomp testing, the convention has been to use a
On Sun, 6 Oct 2024 09:15:58 GMT, SendaoYan wrote:
> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
> mode.
Thanks for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/21375#issuecomment-2397159519
On Sun, 6 Oct 2024 09:15:58 GMT, SendaoYan wrote:
> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
> mode.
Marked as reviewed by jvernee (Reviewer).
FWIW, I think it would be okay to disable this test on -Xcomp altogether. It
tests a very precise race, so -Xcomp pr
A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp mode.
-
Commit messages:
- 8341593: Problemlist java/foreign/TestUpcallStress.java in Xcomp mode
Changes: https://git.openjdk.org/jdk/pull/21375/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21375&
