Re: RFR: 8341399: Add since checker tests to the langtools modules [v6]

2024-11-07 Thread Vicente Romero
On Mon, 4 Nov 2024 18:30:50 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds `@since` checker tests to the >> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. >> The initial test for `java.base` has been integrated in >> [JDK-8331051](https://b

Re: RFR: 8341399: Add since checker tests to the langtools modules [v6]

2024-11-04 Thread Nizar Benalla
> Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). > > The jtreg comment

Re: RFR: 8341399: Add since checker tests to the langtools modules [v5]

2024-11-04 Thread Nizar Benalla
> Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). > > The jtreg comment

Re: RFR: 8341399: Add since checker tests to the langtools modules [v4]

2024-11-01 Thread Nizar Benalla
> Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). > > The jtreg comment

Re: RFR: 8341399: Add since checker tests to the langtools modules [v3]

2024-11-01 Thread Nizar Benalla
> Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). > > The jtreg comment

Re: RFR: 8341399: Add since checker tests to the langtools modules [v2]

2024-11-01 Thread Nizar Benalla
On Fri, 1 Nov 2024 15:51:10 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds `@since` checker tests to the >> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. >> The initial test for `java.base` has been integrated in >> [JDK-8331051](https://b

Re: RFR: 8341399: Add since checker tests to the langtools modules [v2]

2024-11-01 Thread Chen Liang
On Fri, 1 Nov 2024 15:51:10 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds `@since` checker tests to the >> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. >> The initial test for `java.base` has been integrated in >> [JDK-8331051](https://b

Re: RFR: 8341399: Add since checker tests to the langtools modules [v2]

2024-11-01 Thread Nizar Benalla
> Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). > > The jtreg comment

Re: RFR: 8341399: Add since checker tests to the langtools modules [v2]

2024-11-01 Thread Nizar Benalla
On Fri, 1 Nov 2024 15:36:59 GMT, Nizar Benalla wrote: >> test/jdk/tools/sincechecker/jdk_compiler/CheckSince_jdkCompiler.java line 27: >> >>> 25: * @test >>> 26: * @bug 8341399 >>> 27: * @summary Test for `@since` for java.base module >> >> You forgot to change the summaries but remembered t

Re: RFR: 8341399: Add since checker tests to the langtools modules

2024-11-01 Thread Nizar Benalla
On Fri, 1 Nov 2024 15:28:13 GMT, Chen Liang wrote: >> Can I get a review for this patch that adds `@since` checker tests to the >> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. >> The initial test for `java.base` has been integrated in >> [JDK-8331051](https://bugs

Re: RFR: 8341399: Add since checker tests to the langtools modules

2024-11-01 Thread Chen Liang
On Wed, 16 Oct 2024 16:23:41 GMT, Nizar Benalla wrote: > Can I get a review for this patch that adds `@since` checker tests to the > following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. > The initial test for `java.base` has been integrated in > [JDK-8331051](https://bugs

RFR: 8341399: Add since checker tests to the langtools modules

2024-10-16 Thread Nizar Benalla
Can I get a review for this patch that adds `@since` checker tests to the following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps. The initial test for `java.base` has been integrated in [JDK-8331051](https://bugs.openjdk.org/browse/JDK-8331051). The jtreg comments are almost