Re: RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Matthias Baesken
On Tue, 1 Oct 2024 12:22:34 GMT, Aleksey Shipilev wrote: >> This fixes a format string issue. >> >> In the error report it was reported : 'The compiler should be able to catch >> this if JLI_ReportErrorMessageSys was declared with something like >> __attribute__ ((format (printf, 1, 2))).' >>

RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Matthias Baesken
This fixes a format string issue. In the error report it was reported : 'The compiler should be able to catch this if JLI_ReportErrorMessageSys was declared with something like __attribute__ ((format (printf, 1, 2))).' Should we maybe adjust JLI_ReportErrorMessageSys , JLI_ReportErrorMessage a

Re: RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Alan Bateman
On Tue, 1 Oct 2024 07:22:46 GMT, Matthias Baesken wrote: > This fixes a format string issue. > > In the error report it was reported : 'The compiler should be able to catch > this if JLI_ReportErrorMessageSys was declared with something like > __attribute__ ((format (printf, 1, 2))).' > Should

Re: RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Aleksey Shipilev
On Tue, 1 Oct 2024 07:22:46 GMT, Matthias Baesken wrote: > This fixes a format string issue. > > In the error report it was reported : 'The compiler should be able to catch > this if JLI_ReportErrorMessageSys was declared with something like > __attribute__ ((format (printf, 1, 2))).' > Should

Re: RFR: 8341135: Incorrect format string after JDK-8339475 [v2]

2024-10-01 Thread Matthias Baesken
On Tue, 1 Oct 2024 13:15:51 GMT, Matthias Baesken wrote: >> This fixes a format string issue. >> >> In the error report it was reported : 'The compiler should be able to catch >> this if JLI_ReportErrorMessageSys was declared with something like >> __attribute__ ((format (printf, 1, 2))).' >>

Re: RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Christoph Langer
On Tue, 1 Oct 2024 12:40:57 GMT, Matthias Baesken wrote: >> src/java.base/macosx/native/libjli/java_md_macosx.m line 315: >> >>> 313: rc = pthread_create(&main_thr, NULL, &apple_main, &args); >>> 314: if (rc != 0) { >>> 315: JLI_ReportErrorMessageSys("Could not create main thread

Re: RFR: 8341135: Incorrect format string after JDK-8339475 [v2]

2024-10-01 Thread Aleksey Shipilev
On Tue, 1 Oct 2024 13:15:51 GMT, Matthias Baesken wrote: >> This fixes a format string issue. >> >> In the error report it was reported : 'The compiler should be able to catch >> this if JLI_ReportErrorMessageSys was declared with something like >> __attribute__ ((format (printf, 1, 2))).' >>

Re: RFR: 8341135: Incorrect format string after JDK-8339475

2024-10-01 Thread Christoph Langer
On Tue, 1 Oct 2024 07:22:46 GMT, Matthias Baesken wrote: > This fixes a format string issue. > > In the error report it was reported : 'The compiler should be able to catch > this if JLI_ReportErrorMessageSys was declared with something like > __attribute__ ((format (printf, 1, 2))).' > Should

Re: RFR: 8341135: Incorrect format string after JDK-8339475 [v2]

2024-10-01 Thread Matthias Baesken
> This fixes a format string issue. > > In the error report it was reported : 'The compiler should be able to catch > this if JLI_ReportErrorMessageSys was declared with something like > __attribute__ ((format (printf, 1, 2))).' > Should we maybe adjust JLI_ReportErrorMessageSys , JLI_ReportErr