Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Claes Redestad
On Wed, 25 Sep 2024 10:12:50 GMT, Claes Redestad wrote: >> This PR desugars the enum added by JDK-8301873 to reduce classes loaded on >> bootstrap and stored in the default CDS archive by 2. > > Claes Redestad has updated the pull request incrementally with two additional > commits since the la

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Lance Andersen
On Wed, 25 Sep 2024 10:12:50 GMT, Claes Redestad wrote: >> This PR desugars the enum added by JDK-8301873 to reduce classes loaded on >> bootstrap and stored in the default CDS archive by 2. > > Claes Redestad has updated the pull request incrementally with two additional > commits since the la

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Claes Redestad
On Wed, 25 Sep 2024 10:10:13 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/util/zip/ZipCoder.java line 69: >> >>> 67: * to the encoded string. >>> 68: */ >>> 69: EXACT_MATCH = 1, >> >> Would there be any (positive) performance implications of starting

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Eirik Bjørsnøs
On Wed, 25 Sep 2024 10:14:47 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/util/zip/ZipFile.java line 1872: >> >>> 1870: // Compare the lookup name with the name encoded >>> in the CEN >>> 1871: switch (zc.compare(name, cen, noff, nlen,

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Claes Redestad
On Wed, 25 Sep 2024 09:53:39 GMT, Eirik Bjørsnøs wrote: >> Claes Redestad has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Shift constant values >> - Update src/java.base/share/classes/java/util/zip/ZipCoder.java >> >>Co-author

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Claes Redestad
On Wed, 25 Sep 2024 09:52:20 GMT, Eirik Bjørsnøs wrote: >> Claes Redestad has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Shift constant values >> - Update src/java.base/share/classes/java/util/zip/ZipCoder.java >> >>Co-author

Re: RFR: 8340885: Desugar ZipCoder.Comparison [v2]

2024-09-25 Thread Claes Redestad
> This PR desugars the enum added by JDK-8301873 to reduce classes loaded on > bootstrap and stored in the default CDS archive by 2. Claes Redestad has updated the pull request incrementally with two additional commits since the last revision: - Shift constant values - Update src/java.base/sh

Re: RFR: 8340885: Desugar ZipCoder.Comparison

2024-09-25 Thread Eirik Bjørsnøs
On Wed, 25 Sep 2024 09:15:04 GMT, Claes Redestad wrote: > This PR desugars the enum added by JDK-8301873 to reduce classes loaded on > bootstrap and stored in the default CDS archive by 2. Looks good to me, some minor suggestions inline. src/java.base/share/classes/java/util/zip/ZipCoder.java

RFR: 8340885: Desugar ZipCoder.Comparison

2024-09-25 Thread Claes Redestad
This PR desugars the enum added by JDK-8301873 to reduce classes loaded on bootstrap and stored in the default CDS archive by 2. - Commit messages: - Fix docs - Merge branch 'master' into no-comparison - Desugar Comparison enum Changes: https://git.openjdk.org/jdk/pull/21176/file