On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 2 Oct 2024 20:29:10 GMT, David Holmes wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove ubsan changes from jni_md.h
>
> jni_util.h is used across all modules but it is located in
> `java.base/shar
On Wed, 2 Oct 2024 20:29:10 GMT, David Holmes wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove ubsan changes from jni_md.h
>
> jni_util.h is used across all modules but it is located in
> `java.base/shar
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Fri, 11 Oct 2024 18:05:58 GMT, Kim Barrett wrote:
>> Matthias Baesken has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> comm
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Thu, 10 Oct 2024 08:23:42 GMT, Julian Waters wrote:
> I do wonder why the header both here and inside HotSpot is named ub.h instead
> of ubsan.h. Latter sounds better to me, but it doesn't really matter much
I agree it would have probably been better from the start, but at this point
consis
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 2 Oct 2024 20:29:10 GMT, David Holmes wrote:
> jni_util.h is used across all modules but it is located in
> `java.base/share/native/libjava` not `java.base/unix/native/libjava`.
>
> I think you could probably place ub.h along-side jni_util.h in that directory.
Hi David, are you fine w
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at least for now.
>
> The change adds a macro ATTRIBUTE_NO_UBS
On Tue, 8 Oct 2024 11:58:11 GMT, Matthias Baesken wrote:
> We are running it for some weeks now at least once a week in our central
> builds/tests (so far only on Linux x86_64).
That is good to hear. Kudos to you for all your hard work on getting it there!
-
PR Comment: https://gi
On Tue, 8 Oct 2024 10:54:09 GMT, Magnus Ihse Bursie wrote:
>The UBSan functionality is well supported, as such, in the build system. As
>you say, actually building and running a JDK with
> UBSan functionality is not trivial. This just means that we are unlikely to
> e.g. run it continuously on
On Thu, 26 Sep 2024 21:25:07 GMT, Phil Race wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled at lea
On Fri, 4 Oct 2024 09:34:17 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 2 Oct 2024 20:29:10 GMT, David Holmes wrote:
> I think you could probably place ub.h along-side jni_util.h in that directory.
I moved the header to the better location.
-
PR Comment: https://git.openjdk.org/jdk/pull/21184#issuecomment-2393323469
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at least for now.
>
> The change adds a macro ATTRIBUTE_NO_UBS
On Tue, 1 Oct 2024 13:45:56 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 2 Oct 2024 09:38:41 GMT, David Holmes wrote:
> > So maybe src/java.base/unix/native/libjava
>
> That is header files for libjava.
>
> This is why I said it would be hard to find a shared location where this can
> be used across different modules - because there presently isn't one.
In
On Tue, 1 Oct 2024 13:45:56 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Tue, 1 Oct 2024 08:20:43 GMT, Matthias Baesken wrote:
>> `jni_md.h` is shipped as part of every JDK distribution - this change does
>> NOT belong in that file.
>
>> `jni_md.h` is shipped as part of every JDK distribution - this change does
>> NOT belong in that file.
>
> Hi David, should I
On Tue, 1 Oct 2024 08:20:43 GMT, Matthias Baesken wrote:
>> `jni_md.h` is shipped as part of every JDK distribution - this change does
>> NOT belong in that file.
>
>> `jni_md.h` is shipped as part of every JDK distribution - this change does
>> NOT belong in that file.
>
> Hi David, should I
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at least for now.
>
> The change adds a macro ATTRIBUTE_NO_UBS
On Sun, 29 Sep 2024 22:16:47 GMT, David Holmes wrote:
> `jni_md.h` is shipped as part of every JDK distribution - this change does
> NOT belong in that file.
Hi David, should I introduce a separate ub.hpp (similar to what we have in
Hotspot) ?
-
PR Comment: https://git.openjdk.o
On Tue, 1 Oct 2024 08:20:43 GMT, Matthias Baesken wrote:
> Hi David, should I introduce a separate ub.hpp (similar to what we have in
> Hotspot) ?
As previously discussed above a separate header would be best, though I'm not
sure where it would be placed if you are using this across code in di
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Fri, 27 Sep 2024 06:46:24 GMT, Matthias Baesken wrote:
> And it was reviewed by erikj and ihse, I think those are members of the
> OpenJDK build group
Erik and Magnus are indeed part of the build team. Erik is the Skara tool lead
but does build work as well, while Magnus is pretty much the
On Thu, 26 Sep 2024 21:25:07 GMT, Phil Race wrote:
> build team have indicated they do not support --enable-ubsan
What 'build team' are you talking about ? Some Oracle internal build team?
The ubsan support came in 2023, so nothing new (change was from Justin King)
https://github.com/openjdk/jd
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken wrote:
> > jni_md.h seems like a pretty big sledgehammer for something that seems to
> > only be in one file, for just java.desktop. Is this macro planned to be
> > used outside of java.desktop?
>
> Yes I have a couple (currently 2) more I wou
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Thu, 26 Sep 2024 11:51:19 GMT, Matthias Baesken wrote:
> The exclusions should work (similar to HS) for the whole JDK C codebase.
Maybe we can offer a separate header ub.hpp next to jni_md.h that contains the
macro/attribute stuff.
Similar to sanitizers/ub.hpp in HS. This header is then in
On Thu, 26 Sep 2024 10:41:25 GMT, Julian Waters wrote:
> jni_md.h seems like a pretty big sledgehammer for something that seems to
> only be in one file, for just java.desktop. Is this macro planned to be used
> outside of java.desktop?
Yes I have a couple (currently 2) more I would like to ex
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
There is some old awt/2d coding where warnings occur when running with ubsan
enabled binaries.
However at most of these locations the coding should work (at least on our
supported platform set) so the warnings can be disabled at least for now.
The change adds a macro ATTRIBUTE_NO_UBSAN similar
37 matches
Mail list logo
