Re: RFR: 8340554: Improve MessageFormat readObject checks [v2]

2024-10-23 Thread Naoto Sato
On Fri, 18 Oct 2024 19:39:52 GMT, Justin Lu wrote: >> Please review this PR which improves the readObject logic for >> _j.text.MessageFormat_. >> >> No offset should be larger than the pattern length. We already ensure the >> offsets when consumed backwards are equal/descending. The existing

Re: RFR: 8340554: Improve MessageFormat readObject checks [v2]

2024-10-18 Thread Justin Lu
> Please review this PR which improves the readObject logic for > _j.text.MessageFormat_. > > No offset should be larger than the pattern length. We already ensure the > offsets when consumed backwards are equal/descending. The existing > first/initial check was off by 1 since it was checking a

Re: RFR: 8340554: Improve MessageFormat readObject checks

2024-10-18 Thread Naoto Sato
On Thu, 17 Oct 2024 20:14:05 GMT, Justin Lu wrote: > Please review this PR which improves the readObject logic for > _j.text.MessageFormat_. > > No offset should be larger than the pattern length. We already ensure the > offsets when consumed backwards are equal/descending. The existing > fir

RFR: 8340554: Improve MessageFormat readObject checks

2024-10-17 Thread Justin Lu
Please review this PR which improves the readObject logic for _j.text.MessageFormat_. No offset should be larger than the pattern length. We already ensure the offsets when consumed backwards are equal/descending. The existing first/initial check was off by 1 since it was checking against the p