On Fri, 20 Sep 2024 16:35:07 GMT, Shaojin Wen wrote:
>> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
>> size, codeSize is reduced from 367 to 263.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 20 Sep 2024 16:35:05 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>> line 1069:
>>
>>> 1067: localsSize += 2;
>>> 1068: } else {
>>> 1069: if (desc == CD_int || desc == C
On Fri, 20 Sep 2024 16:13:06 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more compact
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 1069:
>
>> 10
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
more compact
-
Changes:
- all: https://git.open
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Tier 1-3 tests pass.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pu
On Fri, 20 Sep 2024 16:13:06 GMT, Claes Redestad wrote:
>> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
>> size, codeSize is reduced from 367 to 263.
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 1069:
>
>> 1067:
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
LGTM
src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
line 1069:
> 1067:
On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen wrote:
> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
> size, codeSize is reduced from 367 to 263.
Looks good. Using `Util.parameterSlots` avoids redundant array allocation and
copies. 👍
-
PR Comment: ht
CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method
size, codeSize is reduced from 367 to 263.
-
Commit messages:
- optimize setLocalsFromArg
Changes: https://git.openjdk.org/jdk/pull/21106/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21106&range
