On Thu, 19 Dec 2024 12:33:40 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Thu, 19 Dec 2024 12:26:12 GMT, Weijun Wang wrote:
>> test/lib/jdk/test/lib/Asserts.java line 448:
>>
>>> 446: if ((unexpected == actual) || (unexpected != null &&
>>> unexpected.equals(actual))) {
>>> 447: msg = Objects.toString(msg, "assertNotEquals")
>>> 448:
On Thu, 19 Dec 2024 10:17:28 GMT, Daniel Jeliński wrote:
>> test/lib/jdk/test/lib/Asserts.java line 256:
>>
>>> 254: * @see #assertNotEqualsByteArray(byte[], byte[], String)
>>> 255: */
>>> 256: public static void assertNotEqualsByteArray(byte[] unexpected,
>>> byte[] actual) {
>>
On Thu, 19 Dec 2024 03:50:59 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> be precise in method spec
>
> test/lib/jdk/test/lib/Asserts.java line 448:
>
>> 446: if ((unexpected == actual)
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow the `assertEquals` style ""expected... but was...".
W
On Thu, 19 Dec 2024 03:19:35 GMT, Valerie Peng wrote:
>> Correct, I'll fix.
>>
>> As for its usages (in `ML_KEM_Test.java` etc), I'll be happy to fix them. In
>> fact, I first noticed those inconsistency and then decided to make the
>> changes here. Would you prefer them to be fixed in this PR
On Thu, 19 Dec 2024 03:33:43 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> be precise in method spec
>
> test/lib/jdk/test/lib/Asserts.java line 256:
>
>> 254: * @see #assertNotEqualsByteAr
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 13:56:14 GMT, Weijun Wang wrote:
>> Also, it's not about "the same byte array", but more like "the same bytes"
>> or have equal values, right? This applies to other methods as well.
>
> Correct, I'll fix.
>
> As for its usages (in `ML_KEM_Test.java` etc), I'll be happy to fi
On Wed, 18 Dec 2024 02:37:05 GMT, Valerie Peng wrote:
>> test/lib/jdk/test/lib/Asserts.java line 244:
>>
>>> 242: * @see #assertEqualsByteArray(byte[], byte[], String)
>>> 243: */
>>> 244: public static void assertEqualsByteArray(byte[] expected, byte[]
>>> actual) {
>>
>> Based
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow the `assertEquals` style ""expected... but was...".
W
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 02:16:55 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow the `assertEquals` style ""expected... but was...".
W
On Tue, 17 Dec 2024 12:57:08 GMT, Daniel Jeliński wrote:
>> Are those calls from me? I know I haven't followed this pattern and I'm
>> thinking about fixing them later.
>>
>> The reason I want to make this change is to make it consistent with the
>> current `assertEquals` method that shows " e
On Tue, 17 Dec 2024 12:57:43 GMT, Daniel Jeliński wrote:
>> test/lib/jdk/test/lib/Asserts.java line 448:
>>
>>> 446: if ((lhs == rhs) || (lhs != null && lhs.equals(rhs))) {
>>> 447: msg = Objects.toString(msg, "assertNotEquals")
>>> 448: + ": expected not
On Mon, 16 Dec 2024 22:32:39 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Tue, 17 Dec 2024 00:48:58 GMT, Weijun Wang wrote:
>> test/lib/jdk/test/lib/Asserts.java line 272:
>>
>>> 270: msg = Objects.toString(msg, "assertEqualsByteArray")
>>> 271: + ": expected " + HexFormat.of().formatHex(lhs)
>>> 272: + " but was
On Mon, 16 Dec 2024 22:31:36 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Mon, 16 Dec 2024 22:28:55 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
`Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
sounds redundant, just say "expected not equals but was 12345".
`Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
Modify it to follow the `assertEquals` style ""expected... but was...".
---
25 matches
Mail list logo
