On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>> c
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>> c
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Fri, 27 Sep 2024 18:08:54 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Thu, 26 Sep 2024 17:24:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Thu, 26 Sep 2024 21:03:20 GMT, Phil Race wrote:
>> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:
>>
>>> 78: 6. Turn on "Adjust for daylight saving time automatically"
>>> 79:
>>> 80: If the local time in the control panel and test window are
>>> alw
On Thu, 26 Sep 2024 16:25:21 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review: update wording of instructions
>
> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 80:
>
>> 78:
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Thu, 26 Sep 2024 17:24:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Thu, 26 Sep 2024 17:06:38 GMT, Daniel Fuchs wrote:
> `test/jdk/sun/net/www/ParseUtil_6380332.java`: shouldn't we actually keep
> this test? I see that the code in ParseUtil which is tested here is still
> there, and I don't think we'd want to touch ParseUtil given potential
> compatibility
On Thu, 26 Sep 2024 17:00:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Wed, 25 Sep 2024 23:32:08 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Wed, 25 Sep 2024 22:06:55 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Wed, 25 Sep 2024 22:03:59 GMT, Justin Lu wrote:
> Not sure if it will be ran by anyone as it is manual,
I don't know about other vendors, but for Oracle, manual tests are run at least
once on every release some time after RDP1 and before RDP2.
-
PR Comment: https://git.openjd
On Wed, 25 Sep 2024 21:36:54 GMT, Naoto Sato wrote:
> Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to
> me. It's a manual test that involves underlying OS settings manipulation
> which cannot be automated.
As we previously spoke offline, I did not think there was muc
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
On Wed, 25 Sep 2024 18:28:02 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
> Please review this PR which removes usages of Applet within the corelibs
> tests. This includes both code usage as well as occurrences of the word.
>
> There were more files found than the ones included in this PR, please see the
> comment on the JBS issue for the reason why they were not incl
Please review this PR which removes usages of Applet within the corelibs tests.
This includes both code usage as well as occurrences of the word.
There were more files found than the ones included in this PR, please see the
comment on the JBS issue for the reason why they were not included. In g
23 matches
Mail list logo
