On Wed, 2 Oct 2024 15:23:52 GMT, Brian Burkhalter wrote:
>> Improve the first sentences of the three `FileInputStream` constructors, in
>> particular removing the term "connection."
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revis
On Wed, 2 Oct 2024 15:23:52 GMT, Brian Burkhalter wrote:
>> Improve the first sentences of the three `FileInputStream` constructors, in
>> particular removing the term "connection."
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revis
On Wed, 2 Oct 2024 06:45:51 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8340229: Revert FIS(fdObj) change
>
> src/java.base/share/classes/java/io/FileInputStream.java line 118:
>
>> 116:
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8340229: Correct typo in FIS
-
Changes:
-
On Tue, 1 Oct 2024 16:08:56 GMT, Brian Burkhalter wrote:
>> Improve the first sentences of the three `FileInputStream` constructors, in
>> particular removing the term "connection."
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revis
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8340229: Revert FIS(fdObj) change
-
Changes:
On Tue, 1 Oct 2024 15:46:49 GMT, Alan Bateman wrote:
>> Updated for the next commit.
>
> Did you push that commit? I don't see the update, the PR only has 1 commit.
I did just now.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21223#discussion_r1783138693
On Mon, 30 Sep 2024 23:13:54 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 118:
>>
>>> 116: /**
>>> 117: * Creates a {@code FileInputStream} to read from an existing file
>>> 118: * named by the {@code File} object {@code file}.
>>
>
On Mon, 30 Sep 2024 23:16:56 GMT, Brian Burkhalter wrote:
> > Do you think, as part of this PR, we should also revisit some of the
> > javadoc in the `java.io.FileOutputStream` class which too has several
> > mentions of "connection"?
>
> Are you thinking of this sentence
>
> `A new FileDescr
On Sun, 29 Sep 2024 07:00:49 GMT, Alan Bateman wrote:
>> Improve the first sentences of the three `FileInputStream` constructors, in
>> particular removing the term "connection."
>
> src/java.base/share/classes/java/io/FileInputStream.java line 166:
>
>> 164: /**
>> 165: * Creates a {@
On Sat, 28 Sep 2024 06:51:19 GMT, Jaikiran Pai wrote:
> Do you think, as part of this PR, we should also revisit some of the javadoc
> in the `java.io.FileOutputStream` class which too has several mentions of
> "connection"?
Are you thinking of this sentence
```A new FileDescriptor object is
On Sat, 28 Sep 2024 06:49:44 GMT, Jaikiran Pai wrote:
>> Improve the first sentences of the three `FileInputStream` constructors, in
>> particular removing the term "connection."
>
> src/java.base/share/classes/java/io/FileInputStream.java line 118:
>
>> 116: /**
>> 117: * Creates a {@
On Fri, 27 Sep 2024 16:06:51 GMT, Brian Burkhalter wrote:
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
src/java.base/share/classes/java/io/FileInputStream.java line 166:
> 164: /**
> 165: * Creates a {@code
On Fri, 27 Sep 2024 16:06:51 GMT, Brian Burkhalter wrote:
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
Do you think, as part of this PR, we should also revisit some of the javadoc in
the `java.io.FileOutputStream` cl
Improve the first sentences of the three `FileInputStream` constructors, in
particular removing the term "connection."
-
Commit messages:
- 8340229: Improve opening sentence of FileInputStream constructor
specification
Changes: https://git.openjdk.org/jdk/pull/21223/files
Webrev
15 matches
Mail list logo
