Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-19 Thread Jaikiran Pai
On Tue, 12 Nov 2024 15:30:23 GMT, Alan Bateman wrote: >> `shortVersionString` changed to `conciseVersionString` in: >> https://github.com/openjdk/jdk/pull/21411/commits/e9e9ad4bdd0a11244cb1ef84fdeea036e94718c7 > >> The idea behind printing the short version is to identify what tool is >> speakin

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-18 Thread Magnus Ihse Bursie
On Mon, 18 Nov 2024 15:55:56 GMT, Jan Lahoda wrote: >> So, just to double-check: given the request is to make the helps consistent, >> and dropping the extensions from the concise help is not what was meant, >> I'll add the extensions both here and to the ordinary help. Correct? > > Done here:

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-18 Thread Jan Lahoda
On Tue, 12 Nov 2024 15:34:16 GMT, Jan Lahoda wrote: >>> @AlanBateman I'd like to respectfully disagree that this was an >>> improvement. If consistency was the important objection here, maybe it >>> would have been better to update "java -help" to include the .jar? >> >> I assume your disagree

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Jan Lahoda
On Tue, 12 Nov 2024 14:04:07 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/launcher/resources/launcher.properties line >> 241: >> >>> 239: \ -jar .jar to execute the main class of a JAR >>> archive\n\ >>> 240: \ -m [/] to execute the main class of a module\n\ >>> 241:

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 13:18:34 GMT, Jan Lahoda wrote: >> The idea behind printing the short version is to identify what tool is >> speaking. It can be removed, if desired. > > `shortVersionString` changed to `conciseVersionString` in: > https://github.com/openjdk/jdk/pull/21411/commits/e9e9ad4bdd0

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Alan Bateman
On Mon, 11 Nov 2024 14:23:46 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits sin

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Magnus Ihse Bursie
On Mon, 11 Nov 2024 14:23:46 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits sin

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Jan Lahoda
On Mon, 11 Nov 2024 14:23:46 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits sin

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Jan Lahoda
On Tue, 12 Nov 2024 13:09:25 GMT, Jan Lahoda wrote: >> In passing, it may be better to pick "short" or "concise", right now it's a >> mix in the method and resource keys. > > The idea behind printing the short version is to identify what tool is > speaking. It can be removed, if desired. `shor

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-12 Thread Jan Lahoda
On Mon, 11 Nov 2024 14:25:57 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 598: >> >>> 596: static void printConciseUsageMessage(boolean printToStderr) { >>> 597: initOutput(printToStderr); >>> 598: >>> ostream.println(SharedSe

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Alan Bateman
On Mon, 11 Nov 2024 08:13:18 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Alan Bateman
On Mon, 11 Nov 2024 14:16:25 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits sin

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Alan Bateman
On Mon, 11 Nov 2024 08:13:18 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Magnus Ihse Bursie
On Mon, 11 Nov 2024 08:13:18 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Jaikiran Pai
On Mon, 11 Nov 2024 08:13:18 GMT, Jan Lahoda wrote: >> Currently, running `java` without any parameters will lead to an output that >> is a full `--help`, which is over 100 lines (on my computer at least), and >> it feels overwhelming. And many people might actually want to run >> JShell/REPL,

Re: RFR: 8340133: Add concise usage message to the java executable [v7]

2024-11-11 Thread Jan Lahoda
> Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not the `java` executable, but it is difficult find out a