Re: RFR: 8340120: Remove redundant code in SegmentBulkOperations::mismatch

2024-09-13 Thread Maurizio Cimadamore
On Fri, 13 Sep 2024 13:59:54 GMT, Per Minborg wrote: > This title has been changed as this code segment was never invoked. So, we > could not add a test that touches the code. Also, this will not fix any > out-of-bounds addressing but will only reduce the code surface. To be clear for future r

Re: RFR: 8340120: Remove redundant code in SegmentBulkOperations::mismatch

2024-09-13 Thread Maurizio Cimadamore
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote: > This PR fixes a build error where we addressed out of bounds. I am now convinced that this was just about dead code - please mark the JBS issue as `noreg-hard`. - Marked as reviewed by mcimadamore (Reviewer). PR Review: https

Re: RFR: 8340120: Remove redundant code in SegmentBulkOperations::mismatch

2024-09-13 Thread Per Minborg
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote: > This PR fixes a build error where we addressed out of bounds. This title has been changed as this code segment was never invoked. So, we could not add a test that touches the code. Also, this will not fix any out-of-bounds addressing but w