On Mon, 30 Sep 2024 09:27:11 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Mon, 30 Sep 2024 09:27:11 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Mon, 30 Sep 2024 09:24:22 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Sat, 28 Sep 2024 13:20:52 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> comm
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native code with
> the transition to Java in JDK 9.
>
> In the
On Wed, 25 Sep 2024 16:22:55 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Wed, 25 Sep 2024 16:22:55 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Thu, 26 Sep 2024 08:50:37 GMT, Eirik Bjørsnøs wrote:
> > I think the changes look reasonable and make sense. Will need to an
> > internal run as well for a sanity check.
>
> @LanceAndersen Was your internal run successful for this change?
Yes I completed this late Tuesday and did not see an
On Tue, 10 Sep 2024 20:09:42 GMT, Lance Andersen wrote:
> I think the changes look reasonable and make sense. Will need to an internal
> run as well for a sanity check.
@LanceAndersen Was your internal run successful for this change?
-
PR Comment: https://git.openjdk.org/jdk/pull/
On Wed, 25 Sep 2024 19:44:46 GMT, Claes Redestad wrote:
> We'd be throwing an OOMError today if we soared too close to the limit
> (Integer.MAX_VALUE - ENDHDR - 2 and above), then throw zerror if we go beyond
> the limit.
I think you might be off by one there :)
The current code incorrectly
On Wed, 25 Sep 2024 16:22:55 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native code with
> the transition to Java in JDK 9.
>
> In the
On Wed, 25 Sep 2024 15:03:57 GMT, Claes Redestad wrote:
> @eirbjo: an alternative suggested offline by @LanceAndersen is that we merge
> the two PRs, since they intermingle a bit too much and have the same goal of
> optimizing initCEN. OK if I merge this into #21133?
My first thought was "that
On Sun, 8 Sep 2024 14:39:06 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native c
On Sun, 8 Sep 2024 14:39:06 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native c
On Sun, 8 Sep 2024 14:39:06 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native c
On Sun, 8 Sep 2024 14:39:06 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
> include the 22-byte trailing`END` header when reading the `CEN` section of
> the ZIP file.
>
> The reading of the END header was probably brought over from native c
Please review this cleanup PR which makes `ZipFile.Source.initCEN` not include
the 22-byte trailing`END` header when reading the `CEN` section of the ZIP file.
The reading of the END header was probably brought over from native code with
the transition to Java in JDK 9.
In the current JDK, the
18 matches
Mail list logo
