Re: RFR: 8339401: Optimize ClassFile load and store instructions [v2]

2024-09-03 Thread Claes Redestad
On Mon, 2 Sep 2024 14:50:33 GMT, Shaojin Wen wrote: >> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size >> greater than 325, break it into multiple small methods and call them >> directly in DirectCodeBuilder > > Shaojin Wen has updated the pull request incrementally

Re: RFR: 8339401: Optimize ClassFile load and store instructions [v2]

2024-09-03 Thread duke
On Mon, 2 Sep 2024 14:50:33 GMT, Shaojin Wen wrote: >> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size >> greater than 325, break it into multiple small methods and call them >> directly in DirectCodeBuilder > > Shaojin Wen has updated the pull request incrementally

Re: RFR: 8339401: Optimize ClassFile load and store instructions [v2]

2024-09-02 Thread Chen Liang
On Mon, 2 Sep 2024 14:50:33 GMT, Shaojin Wen wrote: >> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size >> greater than 325, break it into multiple small methods and call them >> directly in DirectCodeBuilder > > Shaojin Wen has updated the pull request incrementally

Re: RFR: 8339401: Optimize ClassFile load and store instructions [v2]

2024-09-02 Thread Shaojin Wen
> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size > greater than 325, break it into multiple small methods and call them directly > in DirectCodeBuilder Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: sug

Re: RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Chen Liang
On Mon, 2 Sep 2024 14:01:36 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeHelpers.java >> line 61: >> >>> 59: return switch (tk) { >>> 60: case INT, SHORT, BYTE, CHAR, BOOLEAN >>> 61:-> iload(slot); >>

Re: RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Chen Liang
On Wed, 28 Aug 2024 04:14:53 GMT, Shaojin Wen wrote: > BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size > greater than 325, break it into multiple small methods and call them directly > in DirectCodeBuilder src/java.base/share/classes/jdk/internal/classfile/impl/Dir

Re: RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Chen Liang
On Wed, 28 Aug 2024 04:14:53 GMT, Shaojin Wen wrote: > BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size > greater than 325, break it into multiple small methods and call them directly > in DirectCodeBuilder src/java.base/share/classes/jdk/internal/classfile/impl/Byt

Re: RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Shaojin Wen
On Mon, 2 Sep 2024 13:02:40 GMT, Chen Liang wrote: >> BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size >> greater than 325, break it into multiple small methods and call them >> directly in DirectCodeBuilder > > src/java.base/share/classes/jdk/internal/classfile/impl

Re: RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Shaojin Wen
On Wed, 28 Aug 2024 04:14:53 GMT, Shaojin Wen wrote: > BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size > greater than 325, break it into multiple small methods and call them directly > in DirectCodeBuilder @cl4es @liach Is there a better way to ensure that Opcode h

RFR: 8339401: Optimize ClassFile load and store instructions

2024-09-02 Thread Shaojin Wen
BytecodeHelpers' loadOpcode and storeOpcode are large methods with code size greater than 325, break it into multiple small methods and call them directly in DirectCodeBuilder - Commit messages: - suggestion from @liach - copyright - direct call - Break up large methods into sma