On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Thu, 12 Sep 2024 06:33:18 GMT, David Holmes wrote:
>> Can I please get a review of this change which cleans up the code in the
>> `java` launcher? The original motivation for the change was to prevent the
>> `java` launcher's C code from parsing a jar's manifest when launching an
>> applica
On Thu, 12 Sep 2024 06:39:59 GMT, David Holmes wrote:
> Aside: we do an awful lot of Java code execution in the launcher these days
> before we even get to load the real main class. I have to wonder how all this
> affects startup?
In addition to regular regression testing, I also ran existing
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> This was being done in the C code to support a long outdated "JRE selection"
> feature (mJRE https://bugs.openjdk.org/browse/JDK-8058407) which required it
> to parse the jar's manifest.
I would like to note here that the mJRE feature is
Can I please get a review of this change which cleans up the code in the `java`
launcher? The original motivation for the change was to prevent the `java`
launcher's C code from parsing a jar's manifest when launching an application
through `java -jar foo.jar`. The jar parsing code in C currentl
