Re: RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v14]

2024-09-03 Thread Claes Redestad
On Tue, 3 Sep 2024 14:32:16 GMT, Shaojin Wen wrote: >> We might rename these to `countAscii` and `countModifiedUtf8Compatible`. > > ascii includes '\0', `CountModifiedUtf8Compatible` Newbies don't seem to know > what it means I think naming internal low-level methods based precisely on what the

Re: RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v14]

2024-09-03 Thread Shaojin Wen
On Tue, 3 Sep 2024 13:45:26 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 397: >> >>> 395: >>> 396: /** >>> 397: * if string#coder() is Latin1 return the count of string#value() >>> leading greater than zero, else return 0 >> >> Ca

Re: RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v14]

2024-09-03 Thread Chen Liang
On Tue, 3 Sep 2024 12:42:08 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/classes/java/lang/System.java >> >> Co-authored-by: Claes Redestad > > src/java.base/s

Re: RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v14]

2024-09-03 Thread Claes Redestad
On Tue, 3 Sep 2024 12:37:05 GMT, Shaojin Wen wrote: >> Use fast path for ascii characters 1 to 127 to improve the performance of >> writing Utf8Entry to BufferWriter. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > Update s

Re: RFR: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo [v14]

2024-09-03 Thread Shaojin Wen
> Use fast path for ascii characters 1 to 127 to improve the performance of > writing Utf8Entry to BufferWriter. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/java/lang/System.java Co-authored