On Thu, 29 Aug 2024 21:46:52 GMT, Chen Liang wrote:
>> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and
>> confusing. Users should almost always use `loadConstant(ConstantDesc)` for
>> optimized instructions, or use specific factories `iconst_0` etc. or
>> `bipush` with arg
On Sat, 31 Aug 2024 10:16:57 GMT, ExE Boss wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line
>> 679:
>>
>>> 677: getEventConfiguration(blockCodeBuilder);
>>> 678: // stack: [EW] [EW] [EC]
>>> 679: blockCodeBuilder.loadConstant(eventTypeI
On Sat, 31 Aug 2024 09:42:41 GMT, Erik Gahlin wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move bipush and sipush fix from Opcode cleanup to this patch
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumen
On Thu, 29 Aug 2024 21:46:52 GMT, Chen Liang wrote:
>> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and
>> confusing. Users should almost always use `loadConstant(ConstantDesc)` for
>> optimized instructions, or use specific factories `iconst_0` etc. or
>> `bipush` with arg
On Thu, 29 Aug 2024 21:46:52 GMT, Chen Liang wrote:
>> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and
>> confusing. Users should almost always use `loadConstant(ConstantDesc)` for
>> optimized instructions, or use specific factories `iconst_0` etc. or
>> `bipush` with arg
> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and
> confusing. Users should almost always use `loadConstant(ConstantDesc)` for
> optimized instructions, or use specific factories `iconst_0` etc. or `bipush`
> with arguments or `LoadConstantInstruction.of` if they want to spe
8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc)
-
Commit messages:
- Improve specs for ConstantInstruction.ofArgument
- 8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc)
Changes: https://git.openjdk.org/jdk/pull/20779/files
Webrev
