Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-06 Thread Chen Liang
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > remove benc

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-06 Thread Claes Redestad
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > remove benc

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-06 Thread duke
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > remove benc

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-05 Thread Chen Liang
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > remove benc

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-04 Thread Shaojin Wen
On Thu, 5 Sep 2024 05:07:12 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > remove benc

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v8]

2024-09-04 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: remove benchmark - Changes: - all: https://git.openjdk.org/j

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v7]

2024-09-04 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: optimize parameterSlots - Changes: - all: https://git.openjd

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v6]

2024-09-04 Thread Claes Redestad
On Wed, 4 Sep 2024 23:25:30 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes t

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v6]

2024-09-04 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pul

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v5]

2024-09-03 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: suggestion from @cl4es - Changes: - all: https://git.openjdk

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v4]

2024-09-03 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: add benchmark - Changes: - all: https://git.openjdk.org/jdk/

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v3]

2024-09-03 Thread Claes Redestad
On Tue, 3 Sep 2024 13:09:37 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > suggestion

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v3]

2024-09-03 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: suggestion from @liach & @cl4es - Changes: - all: https://gi

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v2]

2024-09-03 Thread Claes Redestad
On Fri, 30 Aug 2024 05:13:33 GMT, Shaojin Wen wrote: >> A small optimization to improve the performance of >> jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > Suggestion

Re: RFR: 8339168: Optimize ClassFile Util slotSize [v2]

2024-08-29 Thread Shaojin Wen
> A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: Suggestions from @cl4es - Changes: - all: https://git.openjd

Re: RFR: 8339168: Optimize ClassFile Util slotSize

2024-08-29 Thread Chen Liang
On Wed, 28 Aug 2024 13:12:35 GMT, Shaojin Wen wrote: > A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot @cl4es Observed that `slotSize` will only get a `CD_void` at method return type; so we can make the non-return-type (so field type

Re: RFR: 8339168: Optimize ClassFile Util slotSize

2024-08-29 Thread duke
On Wed, 28 Aug 2024 13:12:35 GMT, Shaojin Wen wrote: > A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot @wenshao Your change (at version 3c58fab74c9f78b7f3008c4f6fa32a7aab79f053) is now ready to be sponsored by a Committer. -

RFR: 8339168: Optimize ClassFile Util slotSize

2024-08-28 Thread Shaojin Wen
A small optimization to improve the performance of jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot - Commit messages: - optimize slotSize & isDoubleSlot Changes: https://git.openjdk.org/jdk/pull/20747/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20747&range=00

Re: RFR: 8339168: Optimize ClassFile Util slotSize

2024-08-28 Thread Chen Liang
On Wed, 28 Aug 2024 13:12:35 GMT, Shaojin Wen wrote: > A small optimization to improve the performance of > jdk.internal.classfile.impl.Util#slotSize/isDoubleSlot Nice optimization enabled by our PrimitiveClassDesc object sharing. - Marked as reviewed by liach (Reviewer). PR Revi