Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads [v2]

2024-08-28 Thread Claes Redestad
On Wed, 28 Aug 2024 17:51:52 GMT, Claes Redestad wrote: >> Removing PrimitiveEntry reduces boxing/unboxing and removes a class. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Wrong hash for FloatEntryImpl Thanks! -

Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads [v2]

2024-08-28 Thread Chen Liang
On Wed, 28 Aug 2024 17:51:52 GMT, Claes Redestad wrote: >> Removing PrimitiveEntry reduces boxing/unboxing and removes a class. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Wrong hash for FloatEntryImpl Marked as revi

Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads [v2]

2024-08-28 Thread Claes Redestad
> Removing PrimitiveEntry reduces boxing/unboxing and removes a class. Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Wrong hash for FloatEntryImpl - Changes: - all: https://git.openjdk.org/jdk/pull/20749/files -

Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads

2024-08-28 Thread Chen Liang
On Wed, 28 Aug 2024 14:27:45 GMT, Claes Redestad wrote: > Removing PrimitiveEntry reduces boxing/unboxing and removes a class. Changes requested by liach (Reviewer). src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java line 1079: > 1077: > 1078: FloatEntryIm

Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads

2024-08-28 Thread Claes Redestad
On Wed, 28 Aug 2024 14:33:38 GMT, Chen Liang wrote: >> Removing PrimitiveEntry reduces boxing/unboxing and removes a class. > > src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java > line 1044: > >> 1042: @Override >> 1043: void writeTo(BufWriterImpl po

Re: RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads

2024-08-28 Thread Chen Liang
On Wed, 28 Aug 2024 14:27:45 GMT, Claes Redestad wrote: > Removing PrimitiveEntry reduces boxing/unboxing and removes a class. src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java line 1044: > 1042: @Override > 1043: void writeTo(BufWriterImpl pool) {

RFR: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads

2024-08-28 Thread Claes Redestad
Removing PrimitiveEntry reduces boxing/unboxing and removes a class. - Commit messages: - Revert tag rewrite - Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads Changes: https://git.openjdk.org/jdk/pull/20749/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr