Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Claes Redestad
On Mon, 26 Aug 2024 15:00:29 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/ClassFileImpl.java >> line 86: >> >>> 84: var amo = attributeMapperOption; >>> 85: for (var o : options) { >>> 86: if (o instanceof StackMapsOption oo) { >>

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Chen Liang
On Mon, 26 Aug 2024 14:54:59 GMT, Per Minborg wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright > > src/java.base/share/classes/jdk/internal/classfile/impl/ClassFileImpl.java > line 86: > >> 84:

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Per Minborg
On Mon, 26 Aug 2024 13:52:35 GMT, Claes Redestad wrote: >> Noticed these on a few startup tests in code generating proxies. Desugaring >> switch expressions reduce risk of bootstrap circularity from any future >> changes to switch bootstrapping (which itself depends on the classfile API). >> I

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Claes Redestad
On Mon, 26 Aug 2024 13:52:35 GMT, Claes Redestad wrote: >> Noticed these on a few startup tests in code generating proxies. Desugaring >> switch expressions reduce risk of bootstrap circularity from any future >> changes to switch bootstrapping (which itself depends on the classfile API). >> I

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Adam Sotona
On Mon, 26 Aug 2024 13:52:35 GMT, Claes Redestad wrote: >> Noticed these on a few startup tests in code generating proxies. Desugaring >> switch expressions reduce risk of bootstrap circularity from any future >> changes to switch bootstrapping (which itself depends on the classfile API). >> I

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Chen Liang
On Mon, 26 Aug 2024 13:49:25 GMT, Claes Redestad wrote: >> Noticed these on a few startup tests in code generating proxies. Desugaring >> switch expressions reduce risk of bootstrap circularity from any future >> changes to switch bootstrapping (which itself depends on the classfile API). >> I

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API [v2]

2024-08-26 Thread Claes Redestad
> Noticed these on a few startup tests in code generating proxies. Desugaring > switch expressions reduce risk of bootstrap circularity from any future > changes to switch bootstrapping (which itself depends on the classfile API). > It's also a tiny improvement to startup performance. Claes Red

Re: RFR: 8338979: Avoid bootstrapped switches in the classfile API

2024-08-26 Thread Chen Liang
On Mon, 26 Aug 2024 13:39:44 GMT, Claes Redestad wrote: > Noticed these on a few startup tests in code generating proxies. Desugaring > switch expressions reduce risk of bootstrap circularity from any future > changes to switch bootstrapping (which itself depends on the classfile API). > It's

RFR: 8338979: Avoid bootstrapped switches in the classfile API

2024-08-26 Thread Claes Redestad
Noticed these on a few startup tests in code generating proxies. Desugaring switch expressions reduce risk of bootstrap circularity from any future changes to switch bootstrapping (which itself depends on the classfile API). It's also a tiny improvement to startup performance. - Co