Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Andrey Turbanov
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. There is now typo in interface name. `ScheuledThreadPoolExecutor` -> `ScheduledThreadPoolExecutor` - PR

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Alan Bateman
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20653#pullrequestr

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Alan Bateman
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. src/java.base/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java line 533: > 531: */ > 532:

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Doug Lea
On Wed, 21 Aug 2024 11:10:22 GMT, Alan Bateman wrote: >> Unfortunately there is no good, deterministic reproducer which can be used >> as a regression test at this point in time. > > src/java.base/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java > line 533: > >> 531: */

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Doug Lea
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. I think this is the most straightforward way to address. It doesn't need doc change -- there are other cases where b

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Alan Bateman
On Thu, 22 Aug 2024 09:01:43 GMT, Viktor Klang wrote: > Possible duplicates: Yes, a long standing issue. Cap the value at 146 years seems fine, and avoids us needing to put in workarounds at use-sites. - PR Comment: https://git.openjdk.org/jdk/pull/20653#issuecomment-2304192165

RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Viktor Klang
Unfortunately there is no good, deterministic reproducer which can be used as a regression test at this point in time. - Commit messages: - Addressing 8323703 by capping max STPE delay to 146 years Changes: https://git.openjdk.org/jdk/pull/20653/files Webrev: https://webrevs.open

Re: RFR: 8338765: ScheuledThreadPoolExecutor struggles with extremely long delays

2024-08-27 Thread Viktor Klang
On Tue, 20 Aug 2024 18:52:23 GMT, Viktor Klang wrote: > Unfortunately there is no good, deterministic reproducer which can be used as > a regression test at this point in time. @AlanBateman Do you think we could use the https://bugs.openjdk.org/browse/JDK-8338104 reproducer? 🤔 @DougLea Any t