Re: RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource [v2]

2024-08-28 Thread Alan Bateman
On Wed, 28 Aug 2024 18:35:32 GMT, Brent Christian wrote: >> The InterruptibleIO feature (which was only on Solaris) was removed some >> time ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444). >> >> Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should >

Re: RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource [v2]

2024-08-28 Thread Brent Christian
On Wed, 28 Aug 2024 06:32:44 GMT, Alan Bateman wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> move getContentLength() inside try block > > src/java.base/share/classes/jdk/internal/loader/Resource.java line 89:

Re: RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource [v2]

2024-08-28 Thread Brent Christian
> The InterruptibleIO feature (which was only on Solaris) was removed some time > ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444). > > Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should > be removed. Brent Christian has updated the pull request incr

Re: RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource

2024-08-27 Thread Alan Bateman
On Tue, 27 Aug 2024 21:57:16 GMT, Brent Christian wrote: > Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should > be removed. Yes, but aside from cleanup, this also fixes a bug where it clears the interrupt status and doesn't restore it. Good to get this fixed. src/jav

RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource

2024-08-27 Thread Brent Christian
The InterruptibleIO feature (which was only on Solaris) was removed some time ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444). Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should be removed. - Commit messages: - remove handling for defu

Re: RFR: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource

2024-08-27 Thread Brent Christian
On Tue, 27 Aug 2024 21:57:16 GMT, Brent Christian wrote: > The InterruptibleIO feature (which was only on Solaris) was removed some time > ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444). > > Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should > be