Re: RFR: 8338017: Add AOT command-line flag aliases [v7]

2024-10-22 Thread Ioi Lam
On Mon, 14 Oct 2024 05:33:55 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v7]

2024-10-13 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8338017: Add AOT command-line flag aliases [v6]

2024-09-29 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8338017: Add AOT command-line flag aliases [v5]

2024-09-23 Thread David Holmes
On Mon, 23 Sep 2024 17:33:16 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-23 Thread Ioi Lam
On Fri, 20 Sep 2024 01:17:14 GMT, David Holmes wrote: >> Okay both ways are valid, you could also remove the other "!= 0", the mixing >> was confusing > > Hotspot style rule is "no implicit booleans" so the check for `!= 0` should > be used in all cases. Fixed. - PR Review Commen

Re: RFR: 8338017: Add AOT command-line flag aliases [v5]

2024-09-23 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-23 Thread Ioi Lam
On Thu, 19 Sep 2024 21:43:54 GMT, Mat Carter wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: do not check for -XX:AOTMode=create in JLI java.c > > src/hotspot/share/cds/cds_globals.hpp line 102: >

Re: RFR: 8338017: Add AOT command-line flag aliases [v4]

2024-09-19 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread David Holmes
On Thu, 19 Sep 2024 22:06:14 GMT, Mat Carter wrote: >> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 40: >> >>> 38: strcmp(value, "create") != 0 && >>> 39: strcmp(value, "auto") != 0 && >>> 40: strcmp(value, "on")) { >> >> This should be strcmp(value, "on"

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread Mat Carter
On Thu, 19 Sep 2024 21:09:43 GMT, Mat Carter wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: do not check for -XX:AOTMode=create in JLI java.c > > src/hotspot/share/runtime/flags/jvmFlagConstraint

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread Mat Carter
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread Mat Carter
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread Mat Carter
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-09-19 Thread Mat Carter
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-08-30 Thread Vladimir Kozlov
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-08-29 Thread David Holmes
On Thu, 29 Aug 2024 22:11:36 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v2]

2024-08-29 Thread Ioi Lam
On Thu, 29 Aug 2024 05:10:41 GMT, David Holmes wrote: >> src/java.base/share/native/libjli/java.c line 1521: >> >>> 1519: dumpSharedSpaces = JNI_TRUE; >>> 1520: } >>> 1521: if (JLI_StrCmp(arg, "-XX:AOTMode=create") == 0) { >> >> This is inappropriate - the launcher d

Re: RFR: 8338017: Add AOT command-line flag aliases [v3]

2024-08-29 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8338017: Add AOT command-line flag aliases [v2]

2024-08-28 Thread David Holmes
On Thu, 29 Aug 2024 05:05:58 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> sinc

Re: RFR: 8338017: Add AOT command-line flag aliases [v2]

2024-08-28 Thread David Holmes
On Thu, 29 Aug 2024 04:24:02 GMT, Ioi Lam wrote: >> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> Add the following command-line options as specified in JEP 483: >> >> >> - `-XX:AOTMode=off/record/create/auto/on`

Re: RFR: 8338017: Add AOT command-line flag aliases [v2]

2024-08-28 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

RFR: 8338017: Add AOT command-line flag aliases

2024-08-08 Thread Ioi Lam
This is the first PR for [JEP 483: Ahead-of-Time Class Loading & Linking](https://bugs.openjdk.org/browse/JDK-8315737). Add the following command-line options as specified in JEP 483: - `-XX:AOTMode=off/record/create/auto/on` - `-XX:AOTConfiguration=.aotconfig` - `-XX:AOTCache=.aot` These opti