On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
@wenshao
Your change (at version 9d7cc54c449d4e12d0eb30c103e8aa3aaf206b6d) is now ready
to be s
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
LGTM. Thanks for the changes.
-
Marked as reviewed by naoto (Reviewer).
PR Review:
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
Since I am not responsible for the date time area, I would prefer @naotoj who's
more familiar to
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
Below are the performance numbers on the MacBook M1 Pro. In the
zonedDateTimeToString scenario,
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
Change looks fine, but is it actually faster?
-
Marked as reviewed by scolebourne (
Similar to PR #20321, this improves performance by providing a method that
passes in a StringBuilder to avoid unnecessary object allocation.
-
Commit messages:
- copyright
- use var
- Update src/java.base/share/classes/java/time/ZonedDateTime.java
- refactor datetime to string
C
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
src/java.base/share/classes/java/time/ZonedDateTime.java line :
> 2220: if (offset !
