On Mon, 3 Feb 2025 22:31:10 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addit
On Mon, 3 Feb 2025 22:31:10 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addit
On Tue, 3 Sep 2024 17:32:43 GMT, Naoto Sato wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits sin
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
from @natoj
-
On Thu, 30 Jan 2025 14:36:28 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/util/DateTimeHelper.java line 26:
>>
>>> 24: * questions.
>>> 25: */
>>> 26: package jdk.internal.util;
>>
>> Maybe `jdk.internal.time` would be appropriate.
>
> Currently, since we only have the
On Thu, 30 Jan 2025 15:11:28 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Mon, 23 Sep 2024 05:33:53 GMT, Shaojin Wen wrote:
> I don't think using SharedSecret just for performance improvement and code
> size reduction is the right way, as the class is the last resort as the
> header says:
>
> ```
> *
> * Usage of these APIs often means bad encapsulation design
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
do not import stat
On Thu, 30 Jan 2025 14:20:36 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Thu, 30 Jan 2025 14:22:04 GMT, Johannes Graham wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused import
>
> src/java.base/share/classes/jdk/internal/util/DateTimeHelper.java line 26:
>
>> 24: * ques
On Thu, 30 Jan 2025 14:20:36 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
remove unused impo
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
copyright
---
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
On Tue, 3 Sep 2024 17:32:43 GMT, Naoto Sato wrote:
> I don't think using SharedSecret just for performance improvement and code
> size reduction is the right way, as the class is the last resort as the
> header says:
>
> ```
> *
> * Usage of these APIs often means bad encapsulation designs,
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @j
On Tue, 27 Aug 2024 23:49:50 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request with a new target base due
On Tue, 27 Aug 2024 23:49:50 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request with a new target base due
On Tue, 27 Aug 2024 23:49:50 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request with a new target base due
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
breaking out the p
On Sun, 11 Aug 2024 10:13:35 GMT, Stephen Colebourne
wrote:
> A more productive direction might be to move `LocalDate.formatTo` and
> `LocalTime.formatTo` to a JDK internal class (eg. in `jdk.internal.util`?),
> and then edit `LocalTime.formatTo` to handle `fractionalDigits` directly as
> ano
On Sun, 11 Aug 2024 10:17:08 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Sun, 11 Aug 2024 10:13:12 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
copyright
---
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.b
On Sun, 28 Jul 2024 15:52:03 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Sun, 28 Jul 2024 15:52:03 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
1. fix handle frac
On Fri, 26 Jul 2024 15:32:18 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
>> line 3818:
>>
>>> 3816: }
>>> 3817: // add fraction
>>> 3818: if (fractionalDigits > 0) {
>>
>> This breaks the logic. `frac
On Fri, 26 Jul 2024 15:44:59 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Fri, 26 Jul 2024 18:03:18 GMT, Roger Riggs wrote:
> > Could you please review [these](https://github.com/openjdk/jdk/pull/11986)
> > proposed changes for instantiation of `Instant` values with already
> > normalized nanos?
>
> @plokhotnyuk Your contribution cannot be acted upon until the OC
On Fri, 26 Jul 2024 15:53:11 GMT, Andriy Plokhotnyuk wrote:
> Could you please review [these](https://github.com/openjdk/jdk/pull/11986)
> proposed changes for instantiation of `Instant` values with already
> normalized nanos?
@plokhotnyuk Your contribution cannot be acted upon until the OCA i
On Fri, 26 Jul 2024 15:44:59 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add comment
-
On Fri, 26 Jul 2024 15:24:46 GMT, Stephen Colebourne
wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> src/java.base/share/classes/java/time/format/DateTimeFormatt
On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen wrote:
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen wrote:
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
By removing redundant code logic, the codeSize can be reduced from 444 to
By removing the redundant code logic in
DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
reduced and the performance can be improved.
-
Commit messages:
- optimize format instant
Changes: https://git.openjdk.org/jdk/pull/20353/files
Webrev: https://web
41 matches
Mail list logo
