On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Fri, 26 Jul 2024 12:25:24 GMT, Stephen Colebourne
wrote:
> This change is fine, however the comments and performance testing assume that
> a date is always 10 characters long which isn't true, as the year could be
> greater than .
The scenario where year is greater than also works
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit sinc
On Thu, 25 Jul 2024 22:51:09 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit sinc
On Thu, 25 Jul 2024 21:52:03 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with two additional
commits sin
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
src/java.base/share/classes/java
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
LGTM
src/java.base/share/classe
On Thu, 25 Jul 2024 06:19:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Below are the performance
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
@wenshao
Your change (at versio
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Simple and straightforward impro
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Below are the performance number
The current LocalDateTime.toString implementation concatenates the toString
results of date and time, which can be passed to StringBuilder to reduce
additional object allocation and improve performance.
-
Commit messages:
- optimize LocalDateTime.toString, reduce StringBuilder allo
18 matches
Mail list logo